From: cel@kernel.org
To: amir73il@gmail.com, krisman@collabora.com
Cc: gregkh@linuxfoundation.org, jack@suse.cz, sashal@kernel.org,
stable@vger.kernel.org, adilger.kernel@dilger.ca,
linux-ext4@vger.kernel.org, tytso@mit.edu,
alexey.makhalov@broadcom.com, vasavi.sirnapalli@broadcom.com,
florian.fainelli@broadcom.com, Guenter Roeck <linux@roeck-us.net>
Subject: [PATCH v5.10.y 2/3] samples: Make fs-monitor depend on libc and headers
Date: Thu, 25 Jul 2024 11:32:28 -0400 [thread overview]
Message-ID: <20240725153229.13407-3-cel@kernel.org> (raw)
In-Reply-To: <20240725153229.13407-1-cel@kernel.org>
From: Gabriel Krisman Bertazi <krisman@collabora.com>
[ Upstream commit 8fc70b3a142f97f7859bf052151df896933d2586 ]
Prevent build errors when headers or libc are not available, such as on
kernel build bots, like the below:
samples/fanotify/fs-monitor.c:7:10: fatal error: errno.h: No such file
or directory
7 | #include <errno.h>
| ^~~~~~~~~
Link: https://lore.kernel.org/r/87fsslasgz.fsf@collabora.com
Suggested-by: Guenter Roeck <linux@roeck-us.net>
Tested-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Gabriel Krisman Bertazi <krisman@collabora.com>
Signed-off-by: Jan Kara <jack@suse.cz>
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
---
samples/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/samples/Kconfig b/samples/Kconfig
index cecd311ff321..a98e89992a18 100644
--- a/samples/Kconfig
+++ b/samples/Kconfig
@@ -122,7 +122,7 @@ config SAMPLE_CONNECTOR
config SAMPLE_FANOTIFY_ERROR
bool "Build fanotify error monitoring sample"
- depends on FANOTIFY
+ depends on FANOTIFY && CC_CAN_LINK && HEADERS_INSTALL
help
When enabled, this builds an example code that uses the
FAN_FS_ERROR fanotify mechanism to monitor filesystem
--
2.45.2
next prev parent reply other threads:[~2024-07-25 15:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-25 15:32 [PATCH v5.10.y 0/3] Apply fanotify-related documentation changes cel
2024-07-25 15:32 ` [PATCH v5.10.y 1/3] samples: Add fs error monitoring example cel
2024-07-25 15:32 ` cel [this message]
2024-07-25 15:32 ` [PATCH v5.10.y 3/3] Add gitignore file for samples/fanotify/ subdirectory cel
2024-08-13 10:30 ` [PATCH v5.10.y 0/3] Apply fanotify-related documentation changes Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240725153229.13407-3-cel@kernel.org \
--to=cel@kernel.org \
--cc=adilger.kernel@dilger.ca \
--cc=alexey.makhalov@broadcom.com \
--cc=amir73il@gmail.com \
--cc=florian.fainelli@broadcom.com \
--cc=gregkh@linuxfoundation.org \
--cc=jack@suse.cz \
--cc=krisman@collabora.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=sashal@kernel.org \
--cc=stable@vger.kernel.org \
--cc=tytso@mit.edu \
--cc=vasavi.sirnapalli@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox