From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A11F61494B3; Thu, 1 Aug 2024 00:28:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722472139; cv=none; b=tD68Yfglhc9NXCFalUyq494EOUhMWGscS2+8c+sbocUcOiLL9IcJOeXQk4++Xvp0qxZoCdO9r932USBynR3KCeQolGl51jJDPd573U7UqdJunSkUODiWsgenlce2MAitmlmfPcHoo8WSsDfKlH3WqnFEIrCkIIUe5Q42ipzgfRQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722472139; c=relaxed/simple; bh=8Cx5YxP0p8yCWtM9LldCAc2RHlHB0BD+5/0AT9HxaVE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=n+5lidSmfwXPeAzJsVUiS9buVNbIM4P1/4osLJH+7QJo/XZN8hj0yhAsodm8i6l5KQ0/qKLZcmfmcm8Vrr1xOaoffMJ2Ksjo/QF/aeFtNgkSEGfoLzGt9Rhw3ftiC9TmtpZldvaJeAIbozY5J+iycMCCdvrx43277e/0/l/GYC8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=s5qQoyaI; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="s5qQoyaI" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 53153C4AF0F; Thu, 1 Aug 2024 00:28:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1722472139; bh=8Cx5YxP0p8yCWtM9LldCAc2RHlHB0BD+5/0AT9HxaVE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=s5qQoyaIMNknPqxhdiAwkd5QrFQxrvUl7McWIIUHuvPooTJKlUMwtobIutNJKck1c Gl7vdIg3lglJim/ZhfJf5LugNxQvcb0ookV7HL+3omEAFwYQup/uO7dwQivyLYgb+2 SiA4tUQrJ1/N66PE3QPkw5ZM2S68xvAHc+fX02T+3f5cUSWkO5WXaRDruiCAkW7EFd vrtd6yq78gNc0W3/31UjkAY3E3kVt2OZ+7PwQnD8LgoMadV0rmiipeYh5BJdyAuasq meGjV97gia38mZsemYmw2JJ3lq7UDcB/yPZi+tfUwuew6QTvEkgX7RWdDHe3xKvJi1 0geOpzEtdWYhQ== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Hersen Wu , Harry Wentland , Tom Chung , Daniel Wheeler , Alex Deucher , Sasha Levin , sunpeng.li@amd.com, Rodrigo.Siqueira@amd.com, christian.koenig@amd.com, Xinhui.Pan@amd.com, airlied@gmail.com, daniel@ffwll.ch, alex.hung@amd.com, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Subject: [PATCH AUTOSEL 6.1 12/61] drm/amd/display: Fix Coverity INTEGER_OVERFLOW within dal_gpio_service_create Date: Wed, 31 Jul 2024 20:25:30 -0400 Message-ID: <20240801002803.3935985-12-sashal@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240801002803.3935985-1-sashal@kernel.org> References: <20240801002803.3935985-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 6.1.102 Content-Transfer-Encoding: 8bit From: Hersen Wu [ Upstream commit c6077aa66fa230d12f37fef01161ef080d13b726 ] [Why] For subtraction, coverity reports integer overflow warning message when variable type is uint32_t. [How] Change variable type to int32_t. Reviewed-by: Harry Wentland Acked-by: Tom Chung Signed-off-by: Hersen Wu Tested-by: Daniel Wheeler Signed-off-by: Alex Deucher Signed-off-by: Sasha Levin --- drivers/gpu/drm/amd/display/dc/gpio/gpio_service.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/gpio/gpio_service.c b/drivers/gpu/drm/amd/display/dc/gpio/gpio_service.c index 2f8ca831afa2b..f2037d78f71ab 100644 --- a/drivers/gpu/drm/amd/display/dc/gpio/gpio_service.c +++ b/drivers/gpu/drm/amd/display/dc/gpio/gpio_service.c @@ -56,7 +56,7 @@ struct gpio_service *dal_gpio_service_create( struct dc_context *ctx) { struct gpio_service *service; - uint32_t index_of_id; + int32_t index_of_id; service = kzalloc(sizeof(struct gpio_service), GFP_KERNEL); @@ -112,7 +112,7 @@ struct gpio_service *dal_gpio_service_create( return service; failure_2: - while (index_of_id) { + while (index_of_id > 0) { --index_of_id; kfree(service->busyness[index_of_id]); } -- 2.43.0