From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 45AFD19FA65; Thu, 1 Aug 2024 00:31:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722472273; cv=none; b=km5SfoJjBJFCcJMrWRzw0mOTouU76KR487z7U9yvM7mgDZr7RFQptMiJ+l9JHhrGES3GfmOq4y9S1DBJilAPwZQkN9Ke4ximcGUFbZ+Wysyv61Nlv4LBYh6OrmsLDcpi0Caj5pp9uSFSaGX1JH+lD9S9/SNbnH8boZ5UpeZCdE8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722472273; c=relaxed/simple; bh=c1MzbQTkm/Q39eCRZqYS3+IUXU4/3LUeV/eGDaZQZcc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=hBIYm8T4zNQgbVFazcsFwzDKJDMNQO9t50JHWja31NEwPuNrfovTFP8kQ8h9IsrU6nOZ+6SmbK6loPe3Dj0jwD3e/F1RENKCOiSB2+i43YwoTIrhjGtB9tJugTmeBNK0CCf5GEBW3g7L3Izb3exR4Tzyj0t6G4a2fo+NzWMK4VM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=WD+UiMPV; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="WD+UiMPV" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 01DFAC116B1; Thu, 1 Aug 2024 00:31:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1722472273; bh=c1MzbQTkm/Q39eCRZqYS3+IUXU4/3LUeV/eGDaZQZcc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=WD+UiMPVL/wS3gZFpVc5grKkQbiiC3cI0PNlA07IYRUGTTZeGCm5rNckAVtm2jKxK VMkM8gUBHeYiq0W2eXaYHFlvE8jxkIDnSweEJ04xBHpVuyKGDA9b1JoKWOicAEpoTN YPt3ZvK3FT7q4nUo9u2HSpr+XIcgibFzf3/abycJuStUZx8vjh1/RFEZPsf5n3ZlTr V8oeWb3aKNLdHYRhlpqYgP2uOmRoaKOr9vo7qfAcLFgGYwLBeu9UmieRR5wL6eA9kY iRuM2oKrVqtFbG2MSFE/ZnHbaKAaJDtI3iImTCBsziOI0OLF34fQUSXAqh7NDY2UmD UN3+pfl9qiKfA== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Alex Hung , Harry Wentland , Jerry Zuo , Daniel Wheeler , Alex Deucher , Sasha Levin , sunpeng.li@amd.com, Rodrigo.Siqueira@amd.com, christian.koenig@amd.com, Xinhui.Pan@amd.com, airlied@gmail.com, daniel@ffwll.ch, hamza.mahfooz@amd.com, roman.li@amd.com, mario.limonciello@amd.com, Wayne.Lin@amd.com, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Subject: [PATCH AUTOSEL 6.1 50/61] drm/amd/display: Check denominator pbn_div before used Date: Wed, 31 Jul 2024 20:26:08 -0400 Message-ID: <20240801002803.3935985-50-sashal@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240801002803.3935985-1-sashal@kernel.org> References: <20240801002803.3935985-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 6.1.102 Content-Transfer-Encoding: 8bit From: Alex Hung [ Upstream commit 116a678f3a9abc24f5c9d2525b7393d18d9eb58e ] [WHAT & HOW] A denominator cannot be 0, and is checked before used. This fixes 1 DIVIDE_BY_ZERO issue reported by Coverity. Reviewed-by: Harry Wentland Signed-off-by: Jerry Zuo Signed-off-by: Alex Hung Tested-by: Daniel Wheeler Signed-off-by: Alex Deucher Signed-off-by: Sasha Levin --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c index 2c6caddf1de34..b7d2fa77d828b 100644 --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c @@ -6765,7 +6765,7 @@ static int dm_update_mst_vcpi_slots_for_dsc(struct drm_atomic_state *state, } } - if (j == dc_state->stream_count) + if (j == dc_state->stream_count || pbn_div == 0) continue; slot_num = DIV_ROUND_UP(pbn, pbn_div); -- 2.43.0