From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D9EF9126F2A; Wed, 7 Aug 2024 15:13:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723043601; cv=none; b=t+D/gM+9cnxPlCCxhwqj4uxsLAqC2tsStfVFlrTd6M6765TpbmOPi7pWC7mI9QFj1RN9JdnB0yJ7h/zQ3+PHVRKcV33jQFx1JC0wFuvw3wvU6lApiNlkyf3aMWmZFPXZIiLoTKMibw4aOAqzTwpWzTdDmrr0//vafopwJDtP4UM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723043601; c=relaxed/simple; bh=8SnFKmOqLtRGEKMernA0N/Uu5tRvG/M+rHDrgkNLqRs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=HG6UR7oZ+tt3GS8Y67oKJjxPms9L4U/rDndcEfS1aGQDeYHKX80TyoYfaaVwbeoir//sqYi1AZkEcI+FwfpIL8LKXMjG1BES6z8YcwDwd9vB6lAi2ipEKkiF1gxe4BYOH7Z6J+0KSdkEtibgGWrQz4krgkvPMSDqToxy+B7qPXY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=iGqO1CCh; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="iGqO1CCh" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 64B47C4AF0B; Wed, 7 Aug 2024 15:13:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1723043601; bh=8SnFKmOqLtRGEKMernA0N/Uu5tRvG/M+rHDrgkNLqRs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=iGqO1CChOd8N+PUHwM5/jmkpS+TywHcJ4aBFry0n4odtE5Cs4O8EjtgJqRtdZsSlK EpNPrvYmNIFF6tT28CmQYT8wUl8n2z1mR4wzd2aV1X8TGyoo5jBR3+5YAxvF87ZhGS NNzkAJ2O1FCHCS3IZFf5MdtrsrL+mT6hahfxEqBY= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Zhiguo Niu , Chao Yu , Jaegeuk Kim , Sasha Levin Subject: [PATCH 6.1 23/86] f2fs: fix to avoid use SSR allocate when do defragment Date: Wed, 7 Aug 2024 17:00:02 +0200 Message-ID: <20240807150040.003766211@linuxfoundation.org> X-Mailer: git-send-email 2.46.0 In-Reply-To: <20240807150039.247123516@linuxfoundation.org> References: <20240807150039.247123516@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.1-stable review patch. If anyone has any objections, please let me know. ------------------ From: Zhiguo Niu [ Upstream commit 21327a042dd94bc73181d7300e688699cb1f467e ] SSR allocate mode will be used when doing file defragment if ATGC is working at the same time, that is because set_page_private_gcing may make CURSEG_ALL_DATA_ATGC segment type got in f2fs_allocate_data_block when defragment page is writeback, which may cause file fragmentation is worse. A file with 2 fragmentations is changed as following after defragment: ----------------file info------------------- sensorsdata : -------------------------------------------- dev [254:48] ino [0x 3029 : 12329] mode [0x 81b0 : 33200] nlink [0x 1 : 1] uid [0x 27e6 : 10214] gid [0x 27e6 : 10214] size [0x 242000 : 2367488] blksize [0x 1000 : 4096] blocks [0x 1210 : 4624] -------------------------------------------- file_pos start_blk end_blk blks 0 11361121 11361207 87 356352 11361215 11361216 2 364544 11361218 11361218 1 368640 11361220 11361221 2 376832 11361224 11361225 2 385024 11361227 11361238 12 434176 11361240 11361252 13 487424 11361254 11361254 1 491520 11361271 11361279 9 528384 3681794 3681795 2 536576 3681797 3681797 1 540672 3681799 3681799 1 544768 3681803 3681803 1 548864 3681805 3681805 1 552960 3681807 3681807 1 557056 3681809 3681809 1 Signed-off-by: Zhiguo Niu Reviewed-by: Chao Yu Signed-off-by: Jaegeuk Kim Stable-dep-of: 8cb1f4080dd9 ("f2fs: assign CURSEG_ALL_DATA_ATGC if blkaddr is valid") Signed-off-by: Sasha Levin --- fs/f2fs/segment.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c index e19b569d938d8..99391ee4c28c4 100644 --- a/fs/f2fs/segment.c +++ b/fs/f2fs/segment.c @@ -3185,7 +3185,8 @@ static int __get_segment_type_6(struct f2fs_io_info *fio) if (page_private_gcing(fio->page)) { if (fio->sbi->am.atgc_enabled && (fio->io_type == FS_DATA_IO) && - (fio->sbi->gc_mode != GC_URGENT_HIGH)) + (fio->sbi->gc_mode != GC_URGENT_HIGH) && + !is_inode_flag_set(inode, FI_OPU_WRITE)) return CURSEG_ALL_DATA_ATGC; else return CURSEG_COLD_DATA; -- 2.43.0