From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ECC16823DE; Wed, 7 Aug 2024 15:13:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723043632; cv=none; b=OMYGYAe63oP0B9h0zmY/jGifwCUzhXU6q2wOJgQlhmVRCZ10K3m0sEhMjL0avyr55VVweWM8by+DviTF0htYJcrNyfQrvHJmlG8brliWvHPxODjp2ld3WecwuZ9faXuiOo3YQP1wGQMCTG/WSK2pg6yx0ErKqCybC1kyPna6Wyw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723043632; c=relaxed/simple; bh=rfCWkAUMYCLGnDnkALadpdQVsFbxR7ROFC40CMDGgVI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=MCwASI/noKSo4uNctYWi/852fU1uGqdJaFV2HLn1zdRNsVl3eUbvSzP1l5jXgwq62hv3r7/g+XfG5b417HkTZRpMMNe0q11/sqeQ4yOkzssCpKjwKCPhvmU0sE0JIaqWlXvrFBBOMH7wO6EBxQzrEyicdq1mG9JVarbfW5jXr9Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=T8EvmGyr; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="T8EvmGyr" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7E962C32781; Wed, 7 Aug 2024 15:13:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1723043631; bh=rfCWkAUMYCLGnDnkALadpdQVsFbxR7ROFC40CMDGgVI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=T8EvmGyr/JpS8S4TkH8PMAnzReFOjwHJOkHTacnEN7DxKbs42SL1Hy2ruSu4k0/XM eUIqU2kJFu+sAyMttB5uLtVX1MwwWTlM6rWTgKsgZuK8NzLvoA+Rz3M35RMAu6+6+P W4LR2oxpg35cE+GWsuemoFsh15mnKmykz+qu0y+0= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Chao Yu , Will McVicker , Jaegeuk Kim , Sasha Levin Subject: [PATCH 6.1 24/86] f2fs: assign CURSEG_ALL_DATA_ATGC if blkaddr is valid Date: Wed, 7 Aug 2024 17:00:03 +0200 Message-ID: <20240807150040.036225807@linuxfoundation.org> X-Mailer: git-send-email 2.46.0 In-Reply-To: <20240807150039.247123516@linuxfoundation.org> References: <20240807150039.247123516@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.1-stable review patch. If anyone has any objections, please let me know. ------------------ From: Jaegeuk Kim [ Upstream commit 8cb1f4080dd91c6e6b01dbea013a3f42341cb6a1 ] mkdir /mnt/test/comp f2fs_io setflags compression /mnt/test/comp dd if=/dev/zero of=/mnt/test/comp/testfile bs=16k count=1 truncate --size 13 /mnt/test/comp/testfile In the above scenario, we can get a BUG_ON. kernel BUG at fs/f2fs/segment.c:3589! Call Trace: do_write_page+0x78/0x390 [f2fs] f2fs_outplace_write_data+0x62/0xb0 [f2fs] f2fs_do_write_data_page+0x275/0x740 [f2fs] f2fs_write_single_data_page+0x1dc/0x8f0 [f2fs] f2fs_write_multi_pages+0x1e5/0xae0 [f2fs] f2fs_write_cache_pages+0xab1/0xc60 [f2fs] f2fs_write_data_pages+0x2d8/0x330 [f2fs] do_writepages+0xcf/0x270 __writeback_single_inode+0x44/0x350 writeback_sb_inodes+0x242/0x530 __writeback_inodes_wb+0x54/0xf0 wb_writeback+0x192/0x310 wb_workfn+0x30d/0x400 The reason is we gave CURSEG_ALL_DATA_ATGC to COMPR_ADDR where the page was set the gcing flag by set_cluster_dirty(). Cc: stable@vger.kernel.org Fixes: 4961acdd65c9 ("f2fs: fix to tag gcing flag on page during block migration") Reviewed-by: Chao Yu Tested-by: Will McVicker Signed-off-by: Jaegeuk Kim Signed-off-by: Sasha Levin --- fs/f2fs/segment.c | 1 + 1 file changed, 1 insertion(+) diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c index 99391ee4c28c4..1264a350d4d75 100644 --- a/fs/f2fs/segment.c +++ b/fs/f2fs/segment.c @@ -3186,6 +3186,7 @@ static int __get_segment_type_6(struct f2fs_io_info *fio) if (fio->sbi->am.atgc_enabled && (fio->io_type == FS_DATA_IO) && (fio->sbi->gc_mode != GC_URGENT_HIGH) && + __is_valid_data_blkaddr(fio->old_blkaddr) && !is_inode_flag_set(inode, FI_OPU_WRITE)) return CURSEG_ALL_DATA_ATGC; else -- 2.43.0