Re: [PATCH 6.1 00/86] 6.1.104-rc2 review

[Greg Kroah-Hartman <gregkh@linuxfoundation.org>]

On Thu, Aug 08, 2024 at 09:45:57AM -0700, Ron Economos wrote:
> On 8/8/24 7:43 AM, Ron Economos wrote:
> > On 8/8/24 4:55 AM, Ron Economos wrote:
> > > On 8/8/24 2:11 AM, Greg Kroah-Hartman wrote:
> > > > This is the start of the stable review cycle for the 6.1.104 release.
> > > > There are 86 patches in this series, all will be posted as a response
> > > > to this one.  If anyone has any issues with these being applied, please
> > > > let me know.
> > > > 
> > > > Responses should be made by Sat, 10 Aug 2024 09:11:02 +0000.
> > > > Anything received after that time might be too late.
> > > > 
> > > > The whole patch series can be found in one patch at:
> > > >     https://www.kernel.org/pub/linux/kernel/v6.x/stable-review/patch-6.1.104-rc2.gz
> > > > 
> > > > or in the git tree and branch at:
> > > >     git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git
> > > > linux-6.1.y
> > > > and the diffstat can be found below.
> > > > 
> > > > thanks,
> > > > 
> > > > greg k-h
> > > > 
> > > I'm seeing a build failure.
> > > 
> > > sound/pci/hda/patch_conexant.c:273:10: error: ‘const struct
> > > hda_codec_ops’ has no member named ‘suspend’
> > >   273 |         .suspend = cx_auto_suspend,
> > >       |          ^~~~~~~
> > > sound/pci/hda/patch_conexant.c:273:20: error: initialization of
> > > ‘void (*)(struct hda_codec *, hda_nid_t,  unsigned int)’ {aka ‘void
> > > (*)(struct hda_codec *, short unsigned int,  unsigned int)’} from
> > > incompatible pointer type ‘int (*)(struct hda_codec *)’
> > > [-Werror=incompatible-pointer-types]
> > >   273 |         .suspend = cx_auto_suspend,
> > >       |                    ^~~~~~~~~~~~~~~
> > > sound/pci/hda/patch_conexant.c:273:20: note: (near initialization
> > > for ‘cx_auto_patch_ops.set_power_state’)
> > > sound/pci/hda/patch_conexant.c:274:10: error: ‘const struct
> > > hda_codec_ops’ has no member named ‘check_power_status’; did you
> > > mean ‘set_power_state’?
> > >   274 |         .check_power_status = snd_hda_gen_check_power_status,
> > >       |          ^~~~~~~~~~~~~~~~~~
> > >       |          set_power_state
> > > sound/pci/hda/patch_conexant.c:274:31: error:
> > > ‘snd_hda_gen_check_power_status’ undeclared here (not in a
> > > function); did you mean ‘snd_hda_check_power_state’?
> > >   274 |         .check_power_status = snd_hda_gen_check_power_status,
> > >       | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> > >       |                               snd_hda_check_power_state
> > > 
> > > This is triggered because my config does not include CONFIG_PM. But
> > > the error is caused by upstream patch
> > > 9e993b3d722fb452e274e1f8694d8940db183323 "ALSA: hda: codec: Reduce
> > > CONFIG_PM dependencies" being missing. This patch removes the #ifdef
> > > CONFIG_PM in the hda_codec_ops structure. So if CONFIG_PM is not
> > > set, some structure members are missing and the the build fails.
> > > 
> > > 
> > Same failure occurs in 6.6.45-rc1 if CONFIG_PM is not set.
> > 
> > 
> Note: Both upstream 9e993b3d722fb452e274e1f8694d8940db183323 "ALSA: hda:
> codec: Reduce CONFIG_PM dependencies" and
> 6c8fd3499423fc3ebb735f32d4a52bc5825f6301 "ALSA: hda: generic: Reduce
> CONFIG_PM dependencies" are required to fix the build if CONFIG_PM is not
> set.

thanks, I have fixed this all now up.

greg k-h