From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3BC261494B8; Mon, 12 Aug 2024 16:17:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723479470; cv=none; b=HbnW57VJ/GkoxcHk2zTD148M+w43zENbCakOPtX+GFhv1aSmS9dzXjkOzgX5j14mp6OkMLqom8leSVvBrzsxYZCXTbgWslBmAbkffA7wwasX1BMTPssWGjaKurydM8rLpAyCH8dmpA87zFnJm7Ua1ja8TnVoPulFZyexjR1JmDE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723479470; c=relaxed/simple; bh=ldsHjqy9q34qglYRCeSHxCFvnmlpH2ZHXbtCljXuqBU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=jQwnJnViGb5cw29Obvo3QNfClsYgcivZj46CYA65Pt2Tm3vmEARQwJRj3/G6RSoXjdxeQ+FQ7x4uQpQDMyUPFNtKboNnKS138g9bcecSxcYsGl9OXK2CGOIZvmsgdpL41MKkn7LDxbPVK1GyFku0IqCpzn6N3YJO6xC58+4chYQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=BjMOLcop; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="BjMOLcop" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 994E6C32782; Mon, 12 Aug 2024 16:17:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1723479470; bh=ldsHjqy9q34qglYRCeSHxCFvnmlpH2ZHXbtCljXuqBU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=BjMOLcopPAHKtGPmiFFKv1FvsB++rcX5rjUmyvbxzbkNxwOVHiPKjJTlccCEOCpcM wS0D/rHLWmA782DG8ugk2tpYvb6U3FJsOA8gJ2W5t7dRjJ98s7vdfr1plAYSnaoV5X CRDvUhmLQok57JSx08cnyD5bpAB6a1CwhF7meaQw= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Heiko Carstens , Peter Oberparleiter , Alexander Gordeev , Sasha Levin Subject: [PATCH 6.6 066/189] s390/sclp: Prevent release of buffer in I/O Date: Mon, 12 Aug 2024 18:02:02 +0200 Message-ID: <20240812160134.683941500@linuxfoundation.org> X-Mailer: git-send-email 2.46.0 In-Reply-To: <20240812160132.135168257@linuxfoundation.org> References: <20240812160132.135168257@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.6-stable review patch. If anyone has any objections, please let me know. ------------------ From: Peter Oberparleiter [ Upstream commit bf365071ea92b9579d5a272679b74052a5643e35 ] When a task waiting for completion of a Store Data operation is interrupted, an attempt is made to halt this operation. If this attempt fails due to a hardware or firmware problem, there is a chance that the SCLP facility might store data into buffers referenced by the original operation at a later time. Handle this situation by not releasing the referenced data buffers if the halt attempt fails. For current use cases, this might result in a leak of few pages of memory in case of a rare hardware/firmware malfunction. Reviewed-by: Heiko Carstens Signed-off-by: Peter Oberparleiter Signed-off-by: Alexander Gordeev Signed-off-by: Sasha Levin --- drivers/s390/char/sclp_sd.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/s390/char/sclp_sd.c b/drivers/s390/char/sclp_sd.c index f9e164be7568f..944e75beb160c 100644 --- a/drivers/s390/char/sclp_sd.c +++ b/drivers/s390/char/sclp_sd.c @@ -320,8 +320,14 @@ static int sclp_sd_store_data(struct sclp_sd_data *result, u8 di) &esize); if (rc) { /* Cancel running request if interrupted */ - if (rc == -ERESTARTSYS) - sclp_sd_sync(page, SD_EQ_HALT, di, 0, 0, NULL, NULL); + if (rc == -ERESTARTSYS) { + if (sclp_sd_sync(page, SD_EQ_HALT, di, 0, 0, NULL, NULL)) { + pr_warn("Could not stop Store Data request - leaking at least %zu bytes\n", + (size_t)dsize * PAGE_SIZE); + data = NULL; + asce = 0; + } + } vfree(data); goto out; } -- 2.43.0