From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 24B14186E51; Mon, 12 Aug 2024 16:21:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723479709; cv=none; b=GYoYnvfOK6m8PQU3qBwLkE/4ZgXAQyNZLTggNa8S5Q7bMeE+bePNz29YYp052870OrY8Q8D6pCBkY8jYGiUZi2g7kfxdtjbx8BTeRDGSn3OoxVqw+h0jY2KDNq6mHtBBlqwdlKzbzo1oGClJPRNxuQA4bGQQyC/nZ5EpUEnsUvQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723479709; c=relaxed/simple; bh=eE3MMuByY53VucgdwmOhkS9MI/sF+k1qTUMd7zCMqt0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=SGJL+TT/fBgxOyreNi8Tv3zDMoO1H25lXHatM8UihIxMx3S1PDdtCEQaPDdmi3jcmJCMXHhJQw3NYOC6yr9bTRczlo6anOkj/mlqXU5m+RxhQXpoWQRDL8Czo+zQUYrBfq0SytBM8G8og77jb1AMNLgYvD+G1+RhLeQSuaUYIuk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=BSiHJpNa; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="BSiHJpNa" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9C942C32782; Mon, 12 Aug 2024 16:21:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1723479709; bh=eE3MMuByY53VucgdwmOhkS9MI/sF+k1qTUMd7zCMqt0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=BSiHJpNabvBIsrPmUQ8I015DL+22bdxrYivk6MYt8AybYrIn4NLVnEuoH/9V3NckH kHTRTg8IumEhmP6nCN4MSQ0oYjNTgIH9BZ/ewwgsZLtfbPrrWT2UZBkHtyVN0PQhtm BhxDCq/nIoGOhHogiNfnZhmV9w9P7JkOjsoURVBA= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Lucas Stach , Robert Foss Subject: [PATCH 6.6 161/189] drm/bridge: analogix_dp: properly handle zero sized AUX transactions Date: Mon, 12 Aug 2024 18:03:37 +0200 Message-ID: <20240812160138.339818403@linuxfoundation.org> X-Mailer: git-send-email 2.46.0 In-Reply-To: <20240812160132.135168257@linuxfoundation.org> References: <20240812160132.135168257@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.6-stable review patch. If anyone has any objections, please let me know. ------------------ From: Lucas Stach commit e82290a2e0e8ec5e836ecad1ca025021b3855c2d upstream. Address only transactions without any data are valid and should not be flagged as short transactions. Simply return the message size when no transaction errors occured. CC: stable@vger.kernel.org Signed-off-by: Lucas Stach Reviewed-by: Robert Foss Signed-off-by: Robert Foss Link: https://patchwork.freedesktop.org/patch/msgid/20240318203925.2837689-1-l.stach@pengutronix.de Signed-off-by: Greg Kroah-Hartman --- drivers/gpu/drm/bridge/analogix/analogix_dp_reg.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) --- a/drivers/gpu/drm/bridge/analogix/analogix_dp_reg.c +++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_reg.c @@ -1027,7 +1027,6 @@ ssize_t analogix_dp_transfer(struct anal u32 status_reg; u8 *buffer = msg->buffer; unsigned int i; - int num_transferred = 0; int ret; /* Buffer size of AUX CH is 16 bytes */ @@ -1079,7 +1078,6 @@ ssize_t analogix_dp_transfer(struct anal reg = buffer[i]; writel(reg, dp->reg_base + ANALOGIX_DP_BUF_DATA_0 + 4 * i); - num_transferred++; } } @@ -1127,7 +1125,6 @@ ssize_t analogix_dp_transfer(struct anal reg = readl(dp->reg_base + ANALOGIX_DP_BUF_DATA_0 + 4 * i); buffer[i] = (unsigned char)reg; - num_transferred++; } } @@ -1144,7 +1141,7 @@ ssize_t analogix_dp_transfer(struct anal (msg->request & ~DP_AUX_I2C_MOT) == DP_AUX_NATIVE_READ) msg->reply = DP_AUX_NATIVE_REPLY_ACK; - return num_transferred > 0 ? num_transferred : -EBUSY; + return msg->size; aux_error: /* if aux err happen, reset aux */