From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F30CB1DDF5; Thu, 15 Aug 2024 13:29:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723728587; cv=none; b=URzFF7hPZDu4XawYFsxMyt4VKGvF0lRXcmG0VomK77mL89ylgXik+Jclnh4cNmnmBXnZwrO3E3UqJCN575JVwlvBLKaMssRIyByLpVYl2BFnFFFyuyqtXSJIbCaG2/QFQJCCPge/3W0QX1JhSnGecBdsFSB5sxK90mjG2jMrlFo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723728587; c=relaxed/simple; bh=yjWxMf9PsqpTb84zjuW84w1Pn5MzNsIkhkezAUqGmMw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=DgijjKd7NTsIAYZIXvXQnzuqkvpwmJTe6wxPgvI6A+uvIadrGEnGeppzE1WUD+1XVycOPmYQhnBu06Ru1OR9MkgB4yfT6gIjXaHgqia2IfleFLdF728K/bmkvvUofssy0MoIpYhr21fXS2wZqTXYzPmiF9ZjJWUF4CjYqQExMQA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=hRhgz5FD; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="hRhgz5FD" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4AE87C4AF14; Thu, 15 Aug 2024 13:29:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1723728586; bh=yjWxMf9PsqpTb84zjuW84w1Pn5MzNsIkhkezAUqGmMw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=hRhgz5FDXTlO+WaBC8izpS/U8jGl3wbREYw8IEWnT/D/mlPvjgl9iWccZyAZSeoxa 7whJEvULrm6cOHYMU8rIdSjjdT3jAnXuhCQ8O8U0kbeYdDfgVb0vXdFO1KiY4eOHD+ DinIq89TiuFA/RxOaK2rluFOvRyoUB0Z+98mRVQE= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Thorsten Blum , Geert Uytterhoeven , Sasha Levin Subject: [PATCH 4.19 016/196] m68k: cmpxchg: Fix return value for default case in __arch_xchg() Date: Thu, 15 Aug 2024 15:22:13 +0200 Message-ID: <20240815131852.697589301@linuxfoundation.org> X-Mailer: git-send-email 2.46.0 In-Reply-To: <20240815131852.063866671@linuxfoundation.org> References: <20240815131852.063866671@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 4.19-stable review patch. If anyone has any objections, please let me know. ------------------ From: Thorsten Blum [ Upstream commit 21b9e722ad28c19c2bc83f18f540b3dbd89bf762 ] The return value of __invalid_xchg_size() is assigned to tmp instead of the return variable x. Assign it to x instead. Fixes: 2501cf768e4009a0 ("m68k: Fix xchg/cmpxchg to fail to link if given an inappropriate pointer") Signed-off-by: Thorsten Blum Reviewed-by: Geert Uytterhoeven Link: https://lore.kernel.org/20240702034116.140234-2-thorsten.blum@toblux.com Signed-off-by: Geert Uytterhoeven Signed-off-by: Sasha Levin --- arch/m68k/include/asm/cmpxchg.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/m68k/include/asm/cmpxchg.h b/arch/m68k/include/asm/cmpxchg.h index 38e1d7acc44dc..1f996713ce876 100644 --- a/arch/m68k/include/asm/cmpxchg.h +++ b/arch/m68k/include/asm/cmpxchg.h @@ -33,7 +33,7 @@ static inline unsigned long __xchg(unsigned long x, volatile void * ptr, int siz x = tmp; break; default: - tmp = __invalid_xchg_size(x, ptr, size); + x = __invalid_xchg_size(x, ptr, size); break; } -- 2.43.0