From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6F2247DA8A; Thu, 15 Aug 2024 13:30:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723728612; cv=none; b=tybHcCjEfs4tnBLAIsidiFXvdg1QsQNGY9fM/oSa0ARNUyReSGF5fIk7gQOdjwAGJqrMftn0jJAzFlMZPJEHqHg8JxL7AxWzyoAGbL6iALDMuVfMK0U3TFTf6YMtHd8PoD63HIQiQrTy+xiXh8kuo+IKJ4T2HHgljWJDqxSTQmo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723728612; c=relaxed/simple; bh=Q+J925H/VQRR7YDbQ92/j0BnPq+zREmWB/o+z+vZxlI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=jvf1oSuVNnY3MhzWTDwRbSpRyj5IaNDiCY+O/6EFVmslRce7Fdym+QJYq/g7RoqatiHRSMvQZHJcsVez41vweQU4xHGWFawI7zGFTIhA/5zCNRkea7ckoqCi+C5bkt86RcPgn8VqhOM+38Po+LfKqj4UVeEyGwwGbppOYwAuRPM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=YetB2iNK; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="YetB2iNK" Received: by smtp.kernel.org (Postfix) with ESMTPSA id EE42FC32786; Thu, 15 Aug 2024 13:30:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1723728612; bh=Q+J925H/VQRR7YDbQ92/j0BnPq+zREmWB/o+z+vZxlI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=YetB2iNK0217zLcaY4De9ikmmz3d9QZXd256tNHZrFIEHDuqOTzoQ9Yaz2Ab1gbCO rkWD7dq/1GJ9CeG1OyfZA+aGkM1ndCOG4ir8MULQmyPuKYlsBZ+LRareZnVq3gMXvd q77XKaMW+x6gtr6LUnuDyfegck45q/4JlCW56jiA= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Yang Yingliang , Dan Carpenter , Linus Walleij , Sasha Levin Subject: [PATCH 4.19 055/196] pinctrl: core: fix possible memory leak when pinctrl_enable() fails Date: Thu, 15 Aug 2024 15:22:52 +0200 Message-ID: <20240815131854.183911957@linuxfoundation.org> X-Mailer: git-send-email 2.46.0 In-Reply-To: <20240815131852.063866671@linuxfoundation.org> References: <20240815131852.063866671@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 4.19-stable review patch. If anyone has any objections, please let me know. ------------------ From: Yang Yingliang [ Upstream commit ae1cf4759972c5fe665ee4c5e0c29de66fe3cf4a ] In devm_pinctrl_register(), if pinctrl_enable() fails in pinctrl_register(), the "pctldev" has not been added to dev resources, so devm_pinctrl_dev_release() can not be called, it leads memory leak. Introduce pinctrl_uninit_controller(), call it in the error path to free memory. Fixes: 5038a66dad01 ("pinctrl: core: delete incorrect free in pinctrl_enable()") Signed-off-by: Yang Yingliang Reviewed-by: Dan Carpenter Link: https://lore.kernel.org/r/20240606023704.3931561-2-yangyingliang@huawei.com Signed-off-by: Linus Walleij Signed-off-by: Sasha Levin --- drivers/pinctrl/core.c | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/drivers/pinctrl/core.c b/drivers/pinctrl/core.c index 97b1fa3a5e78d..8c52bfac1cc24 100644 --- a/drivers/pinctrl/core.c +++ b/drivers/pinctrl/core.c @@ -1992,6 +1992,14 @@ pinctrl_init_controller(struct pinctrl_desc *pctldesc, struct device *dev, return ERR_PTR(ret); } +static void pinctrl_uninit_controller(struct pinctrl_dev *pctldev, struct pinctrl_desc *pctldesc) +{ + pinctrl_free_pindescs(pctldev, pctldesc->pins, + pctldesc->npins); + mutex_destroy(&pctldev->mutex); + kfree(pctldev); +} + static int pinctrl_claim_hogs(struct pinctrl_dev *pctldev) { pctldev->p = create_pinctrl(pctldev->dev, pctldev); @@ -2072,8 +2080,10 @@ struct pinctrl_dev *pinctrl_register(struct pinctrl_desc *pctldesc, return pctldev; error = pinctrl_enable(pctldev); - if (error) + if (error) { + pinctrl_uninit_controller(pctldev, pctldesc); return ERR_PTR(error); + } return pctldev; -- 2.43.0