From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CC6421714AE; Thu, 15 Aug 2024 13:30:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723728652; cv=none; b=G2f1q8FgdPZFE4czgFexZggmO3pjOERYQL0J+KCHYaNO2UdvAY1JJ2lhUwl1THskWoG1XRVxNQ8LNH/VTX3JSkgKYndQ51r3ICYw0hdv55A3b6CZ+v0tKYTnTclzZLgk2Om4thEdl8rHF+mM5myvs8t+47MNRmqa+3aNi3qqJlc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723728652; c=relaxed/simple; bh=cgTdBG2asivUJweevbmVfmr/TWBJrfdBf68Hsx3WymY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=rizPmRunWNpXLKqYgnrqLZzdRqtHWAAbPwN6Z+nDMHbl4Gy9tMyBDe/4qfBQVu/EqUQ9lIHQBZH4qXPOBB1QKb6FthvV0i5D4W4KAb8sQ37jeiXnSNQQbE2neD2ob+LdEY8gr5Og0znBRmsvZj6ScEC7jqX4GvL9ZTpNzmSdA98= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=X65HJImn; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="X65HJImn" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4D4E4C32786; Thu, 15 Aug 2024 13:30:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1723728652; bh=cgTdBG2asivUJweevbmVfmr/TWBJrfdBf68Hsx3WymY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=X65HJImnLmSLZLK2iwN8TBtUtnpcU/savIFU26PBQqI2cRjzQ9Nt+N3G8SKZo/9kl yltVHp9HnD0O/4PN83ruLg9+arL+JwlLTPLprZG2aKb13fF4McVRl3996NmrZryzxd 5VimHpq65VAsUi2n0fb5OiynpdqQyK6wkqp0ev8M= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Dikshita Agarwal , Vikash Garodia , Stanimir Varbanov , Hans Verkuil Subject: [PATCH 4.19 067/196] media: venus: fix use after free in vdec_close Date: Thu, 15 Aug 2024 15:23:04 +0200 Message-ID: <20240815131854.639855158@linuxfoundation.org> X-Mailer: git-send-email 2.46.0 In-Reply-To: <20240815131852.063866671@linuxfoundation.org> References: <20240815131852.063866671@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 4.19-stable review patch. If anyone has any objections, please let me know. ------------------ From: Dikshita Agarwal commit a0157b5aa34eb43ec4c5510f9c260bbb03be937e upstream. There appears to be a possible use after free with vdec_close(). The firmware will add buffer release work to the work queue through HFI callbacks as a normal part of decoding. Randomly closing the decoder device from userspace during normal decoding can incur a read after free for inst. Fix it by cancelling the work in vdec_close. Cc: stable@vger.kernel.org Fixes: af2c3834c8ca ("[media] media: venus: adding core part and helper functions") Signed-off-by: Dikshita Agarwal Acked-by: Vikash Garodia Signed-off-by: Stanimir Varbanov Signed-off-by: Hans Verkuil Signed-off-by: Greg Kroah-Hartman --- drivers/media/platform/qcom/venus/vdec.c | 1 + 1 file changed, 1 insertion(+) --- a/drivers/media/platform/qcom/venus/vdec.c +++ b/drivers/media/platform/qcom/venus/vdec.c @@ -1096,6 +1096,7 @@ static int vdec_close(struct file *file) { struct venus_inst *inst = to_inst(file); + cancel_work_sync(&inst->delayed_process_work); v4l2_m2m_ctx_release(inst->m2m_ctx); v4l2_m2m_release(inst->m2m_dev); vdec_ctrl_deinit(inst);