From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 32EFB18D630; Thu, 15 Aug 2024 13:34:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723728840; cv=none; b=fzZjgwpWZ2o3zK58mCdjjHHXIPyeuCWSmA72mCgOJJSyLbDsDCGUqU+xFWwZXxdHKlbJDfqSjCRKVRoajXc1r+LhNqKUjkOvxQr6QhLDYF/lmlNjLRfiU8tvnXjcMxigsZD44tFsCPrs/k+p6DSvyzgQORWUU74P61JJS1cIqa8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723728840; c=relaxed/simple; bh=cgMV8bPLG/wCM9QxB7BZh0R0g/KVXadnSwpRpEEPvys=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Jtuu+xeDB4Ks8BJmPKm/SCY+DCR24Zg+U0Tl+nWKBNAQ9BQQi7Ogd1C41FzdmY7mg3443HHOjZ6no5mQKrCU41AgETHIcILH3qrc18ankcQdi4A/AMmb4oiilyC+clcaWWiw8fwVKY97Qmm53tiCVGkr3+qmUm3xNgjiaFa6lqo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=ukcIkf3Q; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="ukcIkf3Q" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A8961C32786; Thu, 15 Aug 2024 13:33:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1723728840; bh=cgMV8bPLG/wCM9QxB7BZh0R0g/KVXadnSwpRpEEPvys=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ukcIkf3QP+6a/jF/89ut86w7/LCeumgDuamQ2Fam7NbUg/Fz3iRYjebYCXTpwO8pW I+YkBc4aoH9swJcobYWhoHTailWaCq1GrZAsoG1wh6SZIE2wUYWqOu87b+TCWrMSuz KbP/keCc2q1XRBfoGVBGrBMhHWJoMDuZ2sxss1Wg= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Sylvain BERTRAND , Takashi Iwai Subject: [PATCH 4.19 127/196] ALSA: usb-audio: Correct surround channels in UAC1 channel map Date: Thu, 15 Aug 2024 15:24:04 +0200 Message-ID: <20240815131856.936153420@linuxfoundation.org> X-Mailer: git-send-email 2.46.0 In-Reply-To: <20240815131852.063866671@linuxfoundation.org> References: <20240815131852.063866671@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 4.19-stable review patch. If anyone has any objections, please let me know. ------------------ From: Takashi Iwai commit b7b7e1ab7619deb3b299b5e5c619c3e6f183a12d upstream. USB-audio driver puts SNDRV_CHMAP_SL and _SR as left and right surround channels for UAC1 channel map, respectively. But they should have been SNDRV_CHMAP_RL and _RR; the current value *_SL and _SR are rather "side" channels, not "surround". I guess I took those mistakenly when I read the spec mentioning "surround left". This patch corrects those entries to be the right channels. Suggested-by: Sylvain BERTRAND Closes: https://lore.kernel.orgZ/qIyJD8lhd8hFhlC@freedom Fixes: 04324ccc75f9 ("ALSA: usb-audio: add channel map support") Cc: Link: https://patch.msgid.link/20240731142018.24750-1-tiwai@suse.de Signed-off-by: Takashi Iwai Signed-off-by: Greg Kroah-Hartman --- sound/usb/stream.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- a/sound/usb/stream.c +++ b/sound/usb/stream.c @@ -250,8 +250,8 @@ static struct snd_pcm_chmap_elem *conver SNDRV_CHMAP_FR, /* right front */ SNDRV_CHMAP_FC, /* center front */ SNDRV_CHMAP_LFE, /* LFE */ - SNDRV_CHMAP_SL, /* left surround */ - SNDRV_CHMAP_SR, /* right surround */ + SNDRV_CHMAP_RL, /* left surround */ + SNDRV_CHMAP_RR, /* right surround */ SNDRV_CHMAP_FLC, /* left of center */ SNDRV_CHMAP_FRC, /* right of center */ SNDRV_CHMAP_RC, /* surround */