From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A81421A01CA; Thu, 15 Aug 2024 13:34:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723728892; cv=none; b=gyUjRfMSx+rzWmvVblSsGJzGo+XNHw8e39JnyRv/7tNNFZdAWY6xyG80GLFcPkJRzXxwe85xtm1ujCazxUIuFG6dFgiPHLpODYiVfv+BvX0Wxr2Xe/Yfhn2fa/TozIimKy440opzcKYtSp8a7uf46TP5yLz9TAmkxjMDqJom5i4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723728892; c=relaxed/simple; bh=KB6BPYPw8OaXAsCYPOht/Qrey4/PhSxGBapW8kTtkDA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=TQIxS9w5vadNxFaZJ8aUYC3nMUZzkAoW2NY390zmQLw+wuENSpPJEZh8E8JcXlECVG1f2wKCnwgqx/paO8HhK1b0AsbSh6Gy0yhjSXpkqHtGpKi5jgw2VkNUqS/76LATHjDYwgKjqJx5GR9+sWu6iT+VcPrEZN2h1Eq7CZjyTCE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=FvbJ2izS; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="FvbJ2izS" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 299F5C32786; Thu, 15 Aug 2024 13:34:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1723728892; bh=KB6BPYPw8OaXAsCYPOht/Qrey4/PhSxGBapW8kTtkDA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=FvbJ2izSfX7HeHe3+5EwkOOh/AHxwEvXRRBffBhcP4wjqXutkLP4IJYphsmvBYxZp ND/MkG85YubkJYTgNiDd6ROAKdeQWXhJ8hsw3MHuVuq65dZ9+WDqoQCGzaej/ww2PX /jNDRWAGCVD34b8gwzkEXGvg/ALWrtKWpnSESV8U= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Michal Pecio , Ricardo Ribalda , Laurent Pinchart , Sasha Levin Subject: [PATCH 4.19 142/196] media: uvcvideo: Fix the bandwdith quirk on USB 3.x Date: Thu, 15 Aug 2024 15:24:19 +0200 Message-ID: <20240815131857.507101719@linuxfoundation.org> X-Mailer: git-send-email 2.46.0 In-Reply-To: <20240815131852.063866671@linuxfoundation.org> References: <20240815131852.063866671@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 4.19-stable review patch. If anyone has any objections, please let me know. ------------------ From: Michal Pecio [ Upstream commit 9e3d55fbd160b3ca376599a68b4cddfdc67d4153 ] The bandwidth fixup quirk doesn't know that SuperSpeed exists and has the same 8 service intervals per millisecond as High Speed, hence its calculations are wrong. Assume that all speeds from HS up use 8 intervals per millisecond. No further changes are needed, updated code has been confirmed to work with all speeds from FS to SS. Signed-off-by: Michal Pecio Reviewed-by: Ricardo Ribalda Reviewed-by: Laurent Pinchart Link: https://lore.kernel.org/r/20240414190040.2255a0bc@foxbook Signed-off-by: Laurent Pinchart Signed-off-by: Sasha Levin --- drivers/media/usb/uvc/uvc_video.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/media/usb/uvc/uvc_video.c b/drivers/media/usb/uvc/uvc_video.c index e2c1b98fb4a25..3f0796141545d 100644 --- a/drivers/media/usb/uvc/uvc_video.c +++ b/drivers/media/usb/uvc/uvc_video.c @@ -212,13 +212,13 @@ static void uvc_fixup_video_ctrl(struct uvc_streaming *stream, /* Compute a bandwidth estimation by multiplying the frame * size by the number of video frames per second, divide the * result by the number of USB frames (or micro-frames for - * high-speed devices) per second and add the UVC header size - * (assumed to be 12 bytes long). + * high- and super-speed devices) per second and add the UVC + * header size (assumed to be 12 bytes long). */ bandwidth = frame->wWidth * frame->wHeight / 8 * format->bpp; bandwidth *= 10000000 / interval + 1; bandwidth /= 1000; - if (stream->dev->udev->speed == USB_SPEED_HIGH) + if (stream->dev->udev->speed >= USB_SPEED_HIGH) bandwidth /= 8; bandwidth += 12; -- 2.43.0