From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E8F1B1AC43B; Thu, 15 Aug 2024 14:12:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723731148; cv=none; b=XMZ0htGq7hGNIFlBe42qOr1rzC8pOdwOucBQZx2WUtlYmI6WZJjvqmeBajEZ92LO5xJNZxTyv8uHDVbp+Ddc5wnLGNxylwiVg88zN2SMOiQ4FuD+hCOu2h4sswvIxIyDu0PDAHrn7QB3oX/BHZ6LuvlDXork/piP072yjjuE4Oo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723731148; c=relaxed/simple; bh=Ye1AfK8RZ1Ghe5fcZBD9AbVdfqseewVYgltptvyWkdc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=hom6ZvFxBK5T1plKsWn8Xlug1KZw+gP0mF0SkGrvEWe+tthVb/REqUEib8G4hJoXIHG5QwairS/A0g96wNnUE69QwvXA7unipbKzE6KdcbBiwJ7WWI70zB98bw6mr3IpTWP7Ma+VG2ka+VVsrd6Covy9mZnaweRwc4gFosFxOr0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=ZU57H6Br; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="ZU57H6Br" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 56F38C32786; Thu, 15 Aug 2024 14:12:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1723731147; bh=Ye1AfK8RZ1Ghe5fcZBD9AbVdfqseewVYgltptvyWkdc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ZU57H6Br9AcGFGc8sd8z8kcwdnq712rHR0cncaqalLL3vr1sk2VLQMYo7n1cgDG8Y +OPmd490ONMGoDYMjCHaqJUUHfPw8KdT5dXTNWLd3XPl7bGHEF7lzpOyIcIeTiXx/7 +ClPDR9JxsQQAzdolUKeZkLWD8jbWpMc8By5FsZM= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Richard Cochran , Andrew Lunn , =?UTF-8?q?Cs=C3=B3k=C3=A1s, =20Bence?= , Wei Fang , "David S. Miller" , Sasha Levin Subject: [PATCH 5.4 038/259] net: fec: Fix FEC_ECR_EN1588 being cleared on link-down Date: Thu, 15 Aug 2024 15:22:51 +0200 Message-ID: <20240815131904.270947245@linuxfoundation.org> X-Mailer: git-send-email 2.46.0 In-Reply-To: <20240815131902.779125794@linuxfoundation.org> References: <20240815131902.779125794@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 5.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Csókás, Bence [ Upstream commit c32fe1986f27cac329767d3497986e306cad1d5e ] FEC_ECR_EN1588 bit gets cleared after MAC reset in `fec_stop()`, which makes all 1588 functionality shut down, and all the extended registers disappear, on link-down, making the adapter fall back to compatibility "dumb mode". However, some functionality needs to be retained (e.g. PPS) even without link. Fixes: 6605b730c061 ("FEC: Add time stamping code and a PTP hardware clock") Cc: Richard Cochran Reviewed-by: Andrew Lunn Link: https://lore.kernel.org/netdev/5fa9fadc-a89d-467a-aae9-c65469ff5fe1@lunn.ch/ Signed-off-by: Csókás, Bence Reviewed-by: Wei Fang Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/ethernet/freescale/fec_main.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/net/ethernet/freescale/fec_main.c b/drivers/net/ethernet/freescale/fec_main.c index cf8426bb6411b..f11824a078e9e 100644 --- a/drivers/net/ethernet/freescale/fec_main.c +++ b/drivers/net/ethernet/freescale/fec_main.c @@ -1205,6 +1205,12 @@ fec_stop(struct net_device *ndev) writel(FEC_ECR_ETHEREN, fep->hwp + FEC_ECNTRL); writel(rmii_mode, fep->hwp + FEC_R_CNTRL); } + + if (fep->bufdesc_ex) { + val = readl(fep->hwp + FEC_ECNTRL); + val |= FEC_ECR_EN1588; + writel(val, fep->hwp + FEC_ECNTRL); + } } static void -- 2.43.0