From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 083A61AD9C5; Thu, 15 Aug 2024 14:12:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723731151; cv=none; b=QOtmvZ7TK3hftz0kJevTnJoDS7LLMViEhgA4LB+eJKtA4kZRDxBeTHIxvt0r1rdH8OzHQ4ZAbQpMTAz9U+llgY0Zrdvj9CvTckWc92FamOZ/EP/rHVrAabUE3GdVBtYAuTHxqj5IohgWtOc1kuNIhfJzrIIQjWMKJFIW15IGJno= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723731151; c=relaxed/simple; bh=9iQYOqUfy4emeHXsnPky7mvpwJYJZ91z//3uDv0gJko=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=KHz4i6I4VT2e5wbdJziaPOmD3m+RBvGrGyRP0HkyEgAVi5A83Zl9cwRoRzWvzpwUCSgS7kz4HKVwVg0DSWydvBx2TJUxD0xvykEBKyDi/TZpDI4ZCXqgrr+mkFhMdt6GN7wsb1j3AkxRGtuU4cjlThiVMTDlpJlnDzDKMGZIxGQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=BK6Ds1wT; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="BK6Ds1wT" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7D417C32786; Thu, 15 Aug 2024 14:12:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1723731150; bh=9iQYOqUfy4emeHXsnPky7mvpwJYJZ91z//3uDv0gJko=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=BK6Ds1wTYdRiigfO+wsOM94GcxQrFxRcKLD148b3h70Gt/+Eg6zixMpduRP4WAD9N 3nF6wIQdIkkdRIhj6PKWXmCs3vJJ8P0PrnvWJTwNniRxC1xx2+o13BBie/8PZi7oJa m1E71anWnICHhfErebmBXwxo+zceb6aRCbKpplJM= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Ismael Luceno , Julian Anastasov , Simon Horman , Pablo Neira Ayuso , Sasha Levin Subject: [PATCH 5.4 039/259] ipvs: Avoid unnecessary calls to skb_is_gso_sctp Date: Thu, 15 Aug 2024 15:22:52 +0200 Message-ID: <20240815131904.311718163@linuxfoundation.org> X-Mailer: git-send-email 2.46.0 In-Reply-To: <20240815131902.779125794@linuxfoundation.org> References: <20240815131902.779125794@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Ismael Luceno [ Upstream commit 53796b03295cf7ab1fc8600016fa6dfbf4a494a0 ] In the context of the SCTP SNAT/DNAT handler, these calls can only return true. Fixes: e10d3ba4d434 ("ipvs: Fix checksumming on GSO of SCTP packets") Signed-off-by: Ismael Luceno Acked-by: Julian Anastasov Acked-by: Simon Horman Signed-off-by: Pablo Neira Ayuso Signed-off-by: Sasha Levin --- net/netfilter/ipvs/ip_vs_proto_sctp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/netfilter/ipvs/ip_vs_proto_sctp.c b/net/netfilter/ipvs/ip_vs_proto_sctp.c index 1e689c7141271..83e452916403d 100644 --- a/net/netfilter/ipvs/ip_vs_proto_sctp.c +++ b/net/netfilter/ipvs/ip_vs_proto_sctp.c @@ -126,7 +126,7 @@ sctp_snat_handler(struct sk_buff *skb, struct ip_vs_protocol *pp, if (sctph->source != cp->vport || payload_csum || skb->ip_summed == CHECKSUM_PARTIAL) { sctph->source = cp->vport; - if (!skb_is_gso(skb) || !skb_is_gso_sctp(skb)) + if (!skb_is_gso(skb)) sctp_nat_csum(skb, sctph, sctphoff); } else { skb->ip_summed = CHECKSUM_UNNECESSARY; @@ -175,7 +175,7 @@ sctp_dnat_handler(struct sk_buff *skb, struct ip_vs_protocol *pp, (skb->ip_summed == CHECKSUM_PARTIAL && !(skb_dst(skb)->dev->features & NETIF_F_SCTP_CRC))) { sctph->dest = cp->dport; - if (!skb_is_gso(skb) || !skb_is_gso_sctp(skb)) + if (!skb_is_gso(skb)) sctp_nat_csum(skb, sctph, sctphoff); } else if (skb->ip_summed != CHECKSUM_PARTIAL) { skb->ip_summed = CHECKSUM_UNNECESSARY; -- 2.43.0