From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C1EFE1AE84C; Thu, 15 Aug 2024 14:13:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723731198; cv=none; b=l79aCiG/O7XN6bkwQXqQrjLIonq33RNg9XezlV2RDRkx7q1c1hKSmkzvg10+hZaM8UftaOl/F45eDM6r8ojNfam/Qgkyrgr5r2XO4EVNByxkYZDhLIcOv+9Pll7PcuMOjtiNWwkbSmCotYA8Zzrz/np9iN9VcK0dYXMhWIO6c94= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723731198; c=relaxed/simple; bh=K4tryUIfjziYn2OCHfSl7PllJIM5KIaRkBbWHqHLOAE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=tuRegmLLvsf+iXNwUZ85LcRNjRgrG4BarkJ5kGpP9hyVZrD9vINK3fqTnC8rK5SA9M+3se3k0v2JQNlgEZY/6rm1lUqv47vCq4zbp8OljueKMWcV8luCDX4mvw1Q4rxsB4X28cP595zTfw/x50sc0Q+HrmqQXTrvPVA+Kxc/9xY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=rJ8ZLar/; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="rJ8ZLar/" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3FFD3C32786; Thu, 15 Aug 2024 14:13:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1723731198; bh=K4tryUIfjziYn2OCHfSl7PllJIM5KIaRkBbWHqHLOAE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=rJ8ZLar/yjL3ZOsjJH8fJxJxTOIFpB5qnvDshJc+M20TLVj9EF/smjH6vHrXCh3Ga acTblcfMf/q8hrd+ZuF6jBfGT6Q0sz8FL9THMAjL0bjoqnQDWHOtTPOTMFQENNa7kE g+nL2v2ueQu0Pax6B/VXSYKQDGXc4s8KRv8KOCwo= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Aleksandr Burakov , Hans Verkuil , Sasha Levin Subject: [PATCH 5.4 053/259] saa7134: Unchecked i2c_transfer function result fixed Date: Thu, 15 Aug 2024 15:23:06 +0200 Message-ID: <20240815131904.855026854@linuxfoundation.org> X-Mailer: git-send-email 2.46.0 In-Reply-To: <20240815131902.779125794@linuxfoundation.org> References: <20240815131902.779125794@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Aleksandr Burakov [ Upstream commit 9d8683b3fd93f0e378f24dc3d9604e5d7d3e0a17 ] Return value of function 'i2c_transfer' is not checked that may cause undefined behaviour. Found by Linux Verification Center (linuxtesting.org) with SVACE. Fixes: 2cf36ac44730 ("[PATCH] v4l: 656: added support for the following cards") Signed-off-by: Aleksandr Burakov Signed-off-by: Hans Verkuil Signed-off-by: Sasha Levin --- drivers/media/pci/saa7134/saa7134-dvb.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/media/pci/saa7134/saa7134-dvb.c b/drivers/media/pci/saa7134/saa7134-dvb.c index f359cd5c006a7..c786b83a69d2b 100644 --- a/drivers/media/pci/saa7134/saa7134-dvb.c +++ b/drivers/media/pci/saa7134/saa7134-dvb.c @@ -466,7 +466,9 @@ static int philips_europa_tuner_sleep(struct dvb_frontend *fe) /* switch the board to analog mode */ if (fe->ops.i2c_gate_ctrl) fe->ops.i2c_gate_ctrl(fe, 1); - i2c_transfer(&dev->i2c_adap, &analog_msg, 1); + if (i2c_transfer(&dev->i2c_adap, &analog_msg, 1) != 1) + return -EIO; + return 0; } @@ -1018,7 +1020,9 @@ static int md8800_set_voltage2(struct dvb_frontend *fe, else wbuf[1] = rbuf & 0xef; msg[0].len = 2; - i2c_transfer(&dev->i2c_adap, msg, 1); + if (i2c_transfer(&dev->i2c_adap, msg, 1) != 1) + return -EIO; + return 0; } -- 2.43.0