From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 68A4938DC8; Thu, 15 Aug 2024 14:14:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723731287; cv=none; b=IehcM55BDwB5fm3lArP7oYlEGHxPPvo7NRqjmiZE+vjnPQkdsah2dwEPg8iW0eILYTCZZkOggyg8LsgaTnPP9DmFYIwZTIAmW3ADwTzcevgV6S0KWp4a8H73vMi1jnSRLuW25fEZNsHclBZrashOqsriODqqoIislL3wcy4FwJU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723731287; c=relaxed/simple; bh=yABv8y0CISWEVIl+DPcWMIQwtQXk4MxluXPzgwtbzDE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=NUwdxKG1dtZDreWR2uBeIv+UEZqYYjIUrig/FXa1EVvsC21Eiybvbmy1qVmpp9+1SshLQ+ye5KneSKmcCM8vGWeDC7Cz3n3k0Go1xFpW0YyTp46ZoV/K46rbEiibuJzEFD0E/Gdb8kPAtoYEfnCDVXzSDT5f4Ob0xdY5Rg8mtV0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=QQapYXwm; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="QQapYXwm" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E0E6DC32786; Thu, 15 Aug 2024 14:14:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1723731287; bh=yABv8y0CISWEVIl+DPcWMIQwtQXk4MxluXPzgwtbzDE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=QQapYXwmDj2Xx/l8m/JsORHu8CTFck4JCWxB1skp4Ss+PmfExUHBiKXM5lEHKamQR HU5R0kSpKzahfJ31tFtLXQNS32oEFADqoah8lf0G1NUFS+bwz9wK/O0clFjR+8Y4RU YQGWoW0PKzjptDXcipitbZY7HMLocK2LNCvdGK2Q= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Yang Yingliang , Dan Carpenter , Linus Walleij , Sasha Levin Subject: [PATCH 5.4 081/259] pinctrl: core: fix possible memory leak when pinctrl_enable() fails Date: Thu, 15 Aug 2024 15:23:34 +0200 Message-ID: <20240815131905.930991395@linuxfoundation.org> X-Mailer: git-send-email 2.46.0 In-Reply-To: <20240815131902.779125794@linuxfoundation.org> References: <20240815131902.779125794@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Yang Yingliang [ Upstream commit ae1cf4759972c5fe665ee4c5e0c29de66fe3cf4a ] In devm_pinctrl_register(), if pinctrl_enable() fails in pinctrl_register(), the "pctldev" has not been added to dev resources, so devm_pinctrl_dev_release() can not be called, it leads memory leak. Introduce pinctrl_uninit_controller(), call it in the error path to free memory. Fixes: 5038a66dad01 ("pinctrl: core: delete incorrect free in pinctrl_enable()") Signed-off-by: Yang Yingliang Reviewed-by: Dan Carpenter Link: https://lore.kernel.org/r/20240606023704.3931561-2-yangyingliang@huawei.com Signed-off-by: Linus Walleij Signed-off-by: Sasha Levin --- drivers/pinctrl/core.c | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/drivers/pinctrl/core.c b/drivers/pinctrl/core.c index 1d8324e220fcf..fa4aec8c4ad54 100644 --- a/drivers/pinctrl/core.c +++ b/drivers/pinctrl/core.c @@ -2017,6 +2017,14 @@ pinctrl_init_controller(struct pinctrl_desc *pctldesc, struct device *dev, return ERR_PTR(ret); } +static void pinctrl_uninit_controller(struct pinctrl_dev *pctldev, struct pinctrl_desc *pctldesc) +{ + pinctrl_free_pindescs(pctldev, pctldesc->pins, + pctldesc->npins); + mutex_destroy(&pctldev->mutex); + kfree(pctldev); +} + static int pinctrl_claim_hogs(struct pinctrl_dev *pctldev) { pctldev->p = create_pinctrl(pctldev->dev, pctldev); @@ -2097,8 +2105,10 @@ struct pinctrl_dev *pinctrl_register(struct pinctrl_desc *pctldesc, return pctldev; error = pinctrl_enable(pctldev); - if (error) + if (error) { + pinctrl_uninit_controller(pctldev, pctldesc); return ERR_PTR(error); + } return pctldev; -- 2.43.0