From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A53961AC8AE; Thu, 15 Aug 2024 14:14:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723731290; cv=none; b=RLPO/lrPyo2UbVuym64sVJiRRuxxL2kBAahhfEOwVGggtSiTLCaPFBBOLsOGYbgwMO0q8ZDKL3HVXNQq41yoEkcOttzkilluG87Keuajacr8BkhO8DEGqvwR3A5+TDXmrhPiDYPwFPKnY3TSIZMAO13nv3pG24CK1aPoCnkqPaM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723731290; c=relaxed/simple; bh=HIBp2HmDF0fD1q5WXVEs5jciEnLyMmgvqFoGIQTeIKA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=RGlq6kg9q1GLOETqeCifkNew0LOkfb8RmqyH8ocmU8FiofU+XyJQ47THyglUtXR6fv8Iw/XBOnsPTnaaNYI9avKfxcQ7sY1js1E2kLIyJ+IbrPq0CqBvJkgKQnsy+VnmVslumrHOorG+EAeP22t8vnylrHabqVqvvwTFN50ete4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=lr6SJFWz; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="lr6SJFWz" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2CA08C32786; Thu, 15 Aug 2024 14:14:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1723731290; bh=HIBp2HmDF0fD1q5WXVEs5jciEnLyMmgvqFoGIQTeIKA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=lr6SJFWzQA8cr+TyJfvwrTXXmRg6mHkyouzSn/0liTAfC9gX/1wT0ZXr0wG8DI7PH 7hSk77qnjc0lLdK2yGt5e/4InQlmmMrsfxgReJpQMiKOcGs8gXvfVlEYSbhhThepp9 ipdNyOvh3kSIqCwnQXierWA7JKnOpORespnwqqaU= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Yang Yingliang , Dan Carpenter , Linus Walleij , Sasha Levin Subject: [PATCH 5.4 082/259] pinctrl: single: fix possible memory leak when pinctrl_enable() fails Date: Thu, 15 Aug 2024 15:23:35 +0200 Message-ID: <20240815131905.969369064@linuxfoundation.org> X-Mailer: git-send-email 2.46.0 In-Reply-To: <20240815131902.779125794@linuxfoundation.org> References: <20240815131902.779125794@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Yang Yingliang [ Upstream commit 8f773bfbdd428819328a2d185976cfc6ae811cd3 ] This driver calls pinctrl_register_and_init() which is not devm_ managed, it will leads memory leak if pinctrl_enable() fails. Replace it with devm_pinctrl_register_and_init(). And call pcs_free_resources() if pinctrl_enable() fails. Fixes: 5038a66dad01 ("pinctrl: core: delete incorrect free in pinctrl_enable()") Signed-off-by: Yang Yingliang Reviewed-by: Dan Carpenter Link: https://lore.kernel.org/r/20240606023704.3931561-3-yangyingliang@huawei.com Signed-off-by: Linus Walleij Signed-off-by: Sasha Levin --- drivers/pinctrl/pinctrl-single.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/pinctrl/pinctrl-single.c b/drivers/pinctrl/pinctrl-single.c index ce5be6f0b7aac..13517243355ce 100644 --- a/drivers/pinctrl/pinctrl-single.c +++ b/drivers/pinctrl/pinctrl-single.c @@ -1311,7 +1311,6 @@ static void pcs_irq_free(struct pcs_device *pcs) static void pcs_free_resources(struct pcs_device *pcs) { pcs_irq_free(pcs); - pinctrl_unregister(pcs->pctl); #if IS_BUILTIN(CONFIG_PINCTRL_SINGLE) if (pcs->missing_nr_pinctrl_cells) @@ -1864,7 +1863,7 @@ static int pcs_probe(struct platform_device *pdev) if (ret < 0) goto free; - ret = pinctrl_register_and_init(&pcs->desc, pcs->dev, pcs, &pcs->pctl); + ret = devm_pinctrl_register_and_init(pcs->dev, &pcs->desc, pcs, &pcs->pctl); if (ret) { dev_err(pcs->dev, "could not register single pinctrl driver\n"); goto free; @@ -1897,8 +1896,10 @@ static int pcs_probe(struct platform_device *pdev) dev_info(pcs->dev, "%i pins, size %u\n", pcs->desc.npins, pcs->size); - return pinctrl_enable(pcs->pctl); + if (pinctrl_enable(pcs->pctl)) + goto free; + return 0; free: pcs_free_resources(pcs); -- 2.43.0