From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B78CA1EA80; Thu, 15 Aug 2024 14:18:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723731488; cv=none; b=TIxfFX1Zn9x+bqSFFoMkEzFSpIA3X3Ku6uUf7E/OmZ+WuLLCTCQ91j8aw0Kn1RKe2S2ra0kPkoVVE5J3Fm67fXPz9TAcJ3P8HsKBFh2me//6uy2z+E4+8k1qK23KBu77xOpFwBF/pLPquImTHb2UOxNiIDmJJ0W6ZZDVrA06Y+U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723731488; c=relaxed/simple; bh=eLowc4rLG8Yu5/3gZAurBap9ljmD8xRAIENcpn5w6vU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=MPajZsir2pxLcTd8jBwnKtF3+isI2YlEkTMagpsAcTfa4hJOXHmH7pd9zQJgJJgb33S57NGqNAfX49rFcYwrgdPS509uLbVjVTw0jStdWB52KsBXOHBW6SWh+OW47U9rxLztikZjLVeEe7mF8d8/tLCqnoXvzhBOy3LQyYgA0hQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=nb2WhLo7; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="nb2WhLo7" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 23258C32786; Thu, 15 Aug 2024 14:18:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1723731488; bh=eLowc4rLG8Yu5/3gZAurBap9ljmD8xRAIENcpn5w6vU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=nb2WhLo7WFZrl32f+H/XpvRqvoVMWVKao5H8PHUOjcH8S8ONvZDza5M/iI14fJBd/ GkgbLS10TAzlWgIiZzGqUJYJ3ONiQ204yPhh9kouG+6gWIetrOj1cuGbnbiPqiXQyV eT+9hGTISZX6GT9kmWSWhQHJpWNvb70bSCv81+7U= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Dan Carpenter , Simon Horman , Jakub Kicinski , Sasha Levin Subject: [PATCH 5.4 146/259] mISDN: Fix a use after free in hfcmulti_tx() Date: Thu, 15 Aug 2024 15:24:39 +0200 Message-ID: <20240815131908.428067652@linuxfoundation.org> X-Mailer: git-send-email 2.46.0 In-Reply-To: <20240815131902.779125794@linuxfoundation.org> References: <20240815131902.779125794@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Dan Carpenter [ Upstream commit 61ab751451f5ebd0b98e02276a44e23a10110402 ] Don't dereference *sp after calling dev_kfree_skb(*sp). Fixes: af69fb3a8ffa ("Add mISDN HFC multiport driver") Signed-off-by: Dan Carpenter Reviewed-by: Simon Horman Link: https://patch.msgid.link/8be65f5a-c2dd-4ba0-8a10-bfe5980b8cfb@stanley.mountain Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin --- drivers/isdn/hardware/mISDN/hfcmulti.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/isdn/hardware/mISDN/hfcmulti.c b/drivers/isdn/hardware/mISDN/hfcmulti.c index 2c74064652334..6e09975613300 100644 --- a/drivers/isdn/hardware/mISDN/hfcmulti.c +++ b/drivers/isdn/hardware/mISDN/hfcmulti.c @@ -1931,7 +1931,7 @@ hfcmulti_dtmf(struct hfc_multi *hc) static void hfcmulti_tx(struct hfc_multi *hc, int ch) { - int i, ii, temp, len = 0; + int i, ii, temp, tmp_len, len = 0; int Zspace, z1, z2; /* must be int for calculation */ int Fspace, f1, f2; u_char *d; @@ -2152,14 +2152,15 @@ hfcmulti_tx(struct hfc_multi *hc, int ch) HFC_wait_nodebug(hc); } + tmp_len = (*sp)->len; dev_kfree_skb(*sp); /* check for next frame */ if (bch && get_next_bframe(bch)) { - len = (*sp)->len; + len = tmp_len; goto next_frame; } if (dch && get_next_dframe(dch)) { - len = (*sp)->len; + len = tmp_len; goto next_frame; } -- 2.43.0