From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DB1F91AC896; Thu, 15 Aug 2024 14:19:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723731584; cv=none; b=oH40ws93Z52DsjNnSlZk/AkqS/dqmAE6NvH3e9K5Rkuam7TXILMSTNU0/8pBtxWZfyayOhXc2n1JEnXiHRvgg9yvirSi/wTgQ2QyowiG45EKVyvkbT6BrSkSygNqCCcr/Q7dL8jWQySEFb7dxT+uXd8HZ4UvjPXcY6hyXdugFKY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723731584; c=relaxed/simple; bh=2gJSEu+6NZjD5ldX9BrLA2OisxGmYPCOJhKRY8YfKmk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=P1bQGavuGaOk0FHJXkNmqpXDxeaghGL4WxdBL3tXxXqcJH6IKjlDGiPcyYz5h+hMnL4wkDopFl6fx2LfPPQ3QGnwz0Rm1cnyFOiIe66aIR6MyMZXG0ne2AdGX+DiBvqCzzVhrtDkorKG3ZQHKkp3HM7mm1g05hleynKOLUFMm8o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=R4WiEpbo; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="R4WiEpbo" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4A015C32786; Thu, 15 Aug 2024 14:19:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1723731584; bh=2gJSEu+6NZjD5ldX9BrLA2OisxGmYPCOJhKRY8YfKmk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=R4WiEpbofs023fU4BABu5OGl31ZLaNyB7tl5tQCIB2YPCWoCukcpLyZGKIEMBn71k U4AQAQGpFd7EtcM9ptHN5eg3GqlzniDAGUHDM2g2NMNMzDJHRXgePZIv4tFlXiSSE0 T8whN1SbjSlKNih9WGQkU2JJXL80K0Qnh/rqMq7c= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Shahar Shitrit , Carolina Jubran , Tariq Toukan , Wojciech Drewek , Jakub Kicinski , Sasha Levin Subject: [PATCH 5.4 176/259] net/mlx5e: Add a check for the return value from mlx5_port_set_eth_ptys Date: Thu, 15 Aug 2024 15:25:09 +0200 Message-ID: <20240815131909.575858221@linuxfoundation.org> X-Mailer: git-send-email 2.46.0 In-Reply-To: <20240815131902.779125794@linuxfoundation.org> References: <20240815131902.779125794@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Shahar Shitrit [ Upstream commit 3f8e82a020a5c22f9b791f4ac499b8e18007fbda ] Since the documentation for mlx5_toggle_port_link states that it should only be used after setting the port register, we add a check for the return value from mlx5_port_set_eth_ptys to ensure the register was successfully set before calling it. Fixes: 667daedaecd1 ("net/mlx5e: Toggle link only after modifying port parameters") Signed-off-by: Shahar Shitrit Reviewed-by: Carolina Jubran Signed-off-by: Tariq Toukan Reviewed-by: Wojciech Drewek Link: https://patch.msgid.link/20240730061638.1831002-9-tariqt@nvidia.com Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin --- drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c b/drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c index 18e0cb02aee18..10411ab89e1cf 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c @@ -1104,7 +1104,12 @@ int mlx5e_ethtool_set_link_ksettings(struct mlx5e_priv *priv, if (!an_changes && link_modes == eproto.admin) goto out; - mlx5_port_set_eth_ptys(mdev, an_disable, link_modes, ext); + err = mlx5_port_set_eth_ptys(mdev, an_disable, link_modes, ext); + if (err) { + netdev_err(priv->netdev, "%s: failed to set ptys reg: %d\n", __func__, err); + goto out; + } + mlx5_toggle_port_link(mdev); out: -- 2.43.0