From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5CF1B7DA7D; Thu, 15 Aug 2024 13:59:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723730368; cv=none; b=QZAqvT9QpPz/mEUVXXouZ00trVwQfiRyvzw6bmcldoymw33NrRYc/LlLYRaYu5Pd82o8zloP+ByhUEGArugMk7pK/CxITjpnZXnnvg+3VSbpcukLVJPp9LfvV5pCO1wv1undVpxmtB8yE6I2M7Y/LYYbAZbMWcO9jOpk5jiniGc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723730368; c=relaxed/simple; bh=XSAk/G+Sx9XQWHFVETnwQVsJOiTRn3D2EkUYeFvdVuo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Uk+UTxdBVglejGhy58MZvjne9RYK+ZMqmfmwJgD5KcoPFtbKrspwFzBcwdZ6IB9rbXG6VPH4aSjW5r4ica+e2P8Ya2r4id0Pdh7xZvt9fGI4Bwrx8MOyzurqf/9jZbptb2fCBg4Oqh2wKJxBJKe5KmDj6GRYzjsrO6O9ap6cJuA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=N1bg7wRS; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="N1bg7wRS" Received: by smtp.kernel.org (Postfix) with ESMTPSA id BCFF4C32786; Thu, 15 Aug 2024 13:59:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1723730368; bh=XSAk/G+Sx9XQWHFVETnwQVsJOiTRn3D2EkUYeFvdVuo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=N1bg7wRSkjO4PxUhEONMSYFP6rtZJrrMlQYGbejiVr79EVtoyE1UAY9eEnKaJHwZj FnA2FhKEuUFuXYFVHkcNXYfF8Erl40IzkJ+5IQK36x+RlHckJsQhTONVSURfuafj05 hXgm7lFhQFkZWsWz6DPOQaUry3s9nVpqjr0G/Glk= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Heiko Carstens , Peter Oberparleiter , Alexander Gordeev , Sasha Levin Subject: [PATCH 5.15 386/484] s390/sclp: Prevent release of buffer in I/O Date: Thu, 15 Aug 2024 15:24:04 +0200 Message-ID: <20240815131956.356414451@linuxfoundation.org> X-Mailer: git-send-email 2.46.0 In-Reply-To: <20240815131941.255804951@linuxfoundation.org> References: <20240815131941.255804951@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.15-stable review patch. If anyone has any objections, please let me know. ------------------ From: Peter Oberparleiter [ Upstream commit bf365071ea92b9579d5a272679b74052a5643e35 ] When a task waiting for completion of a Store Data operation is interrupted, an attempt is made to halt this operation. If this attempt fails due to a hardware or firmware problem, there is a chance that the SCLP facility might store data into buffers referenced by the original operation at a later time. Handle this situation by not releasing the referenced data buffers if the halt attempt fails. For current use cases, this might result in a leak of few pages of memory in case of a rare hardware/firmware malfunction. Reviewed-by: Heiko Carstens Signed-off-by: Peter Oberparleiter Signed-off-by: Alexander Gordeev Signed-off-by: Sasha Levin --- drivers/s390/char/sclp_sd.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/s390/char/sclp_sd.c b/drivers/s390/char/sclp_sd.c index 1e244f78f1929..64581433c3349 100644 --- a/drivers/s390/char/sclp_sd.c +++ b/drivers/s390/char/sclp_sd.c @@ -319,8 +319,14 @@ static int sclp_sd_store_data(struct sclp_sd_data *result, u8 di) &esize); if (rc) { /* Cancel running request if interrupted */ - if (rc == -ERESTARTSYS) - sclp_sd_sync(page, SD_EQ_HALT, di, 0, 0, NULL, NULL); + if (rc == -ERESTARTSYS) { + if (sclp_sd_sync(page, SD_EQ_HALT, di, 0, 0, NULL, NULL)) { + pr_warn("Could not stop Store Data request - leaking at least %zu bytes\n", + (size_t)dsize * PAGE_SIZE); + data = NULL; + asce = 0; + } + } vfree(data); goto out; } -- 2.43.0