Re: [PATCH 4.19] nvme/pci: Add sleep quirk for Samsung and Toshiba drives

[Greg KH <gregkh@linuxfoundation.org>]

On Wed, Jul 31, 2024 at 03:50:46PM +0800, Erpeng Xu wrote:
> From: Shyjumon N <shyjumon.n@intel.com>
> 
> commit 1fae37accfc5872af3905d4ba71dc6ab15829be7 upstream
> 
> The Samsung SSD SM981/PM981 and Toshiba SSD KBG40ZNT256G on the Lenovo
> C640 platform experience runtime resume issues when the SSDs are kept in
> sleep/suspend mode for long time.
> 
> This patch applies the 'Simple Suspend' quirk to these configurations.
> With this patch, the issue had not been observed in a 1+ day test.
> 
> Reviewed-by: Jon Derrick <jonathan.derrick@intel.com>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
> Signed-off-by: Shyjumon N <shyjumon.n@intel.com>
> Signed-off-by: Keith Busch <kbusch@kernel.org>
> Signed-off-by: Erpeng Xu <xuerpeng@uniontech.com>
> ---
>  drivers/nvme/host/pci.c | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
> index 9c80f9f08149..b0434b687b17 100644
> --- a/drivers/nvme/host/pci.c
> +++ b/drivers/nvme/host/pci.c
> @@ -2747,6 +2747,18 @@ static unsigned long check_vendor_combination_bug(struct pci_dev *pdev)
>  		    (dmi_match(DMI_BOARD_NAME, "PRIME B350M-A") ||
>  		     dmi_match(DMI_BOARD_NAME, "PRIME Z370-A")))
>  			return NVME_QUIRK_NO_APST;
> +	} else if ((pdev->vendor == 0x144d && (pdev->device == 0xa801 ||
> +		    pdev->device == 0xa808 || pdev->device == 0xa809)) ||
> +		   (pdev->vendor == 0x1e0f && pdev->device == 0x0001)) {
> +		/*
> +		 * Forcing to use host managed nvme power settings for
> +		 * lowest idle power with quick resume latency on
> +		 * Samsung and Toshiba SSDs based on suspend behavior
> +		 * on Coffee Lake board for LENOVO C640
> +		 */
> +		if ((dmi_match(DMI_BOARD_VENDOR, "LENOVO")) &&
> +		     dmi_match(DMI_BOARD_NAME, "LNVNB161216"))
> +			return NVME_QUIRK_SIMPLE_SUSPEND;
>  	}
>  

This breaks the build, how did you test this?

thanks,

greg k-h