Re: [PATCH 6.6 1/2] genirq/cpuhotplug: Skip suspended interrupts when restoring affinity

[Greg Kroah-Hartman <gregkh@linuxfoundation.org>]

On Wed, Aug 14, 2024 at 11:28:25AM -0700, Bart Van Assche wrote:
> From: David Stevens <stevensd@chromium.org>
> 
> commit a60dd06af674d3bb76b40da5d722e4a0ecefe650 upstream.
> 
> irq_restore_affinity_of_irq() restarts managed interrupts unconditionally
> when the first CPU in the affinity mask comes online. That's correct during
> normal hotplug operations, but not when resuming from S3 because the
> drivers are not resumed yet and interrupt delivery is not expected by them.
> 
> Skip the startup of suspended interrupts and let resume_device_irqs() deal
> with restoring them. This ensures that irqs are not delivered to drivers
> during the noirq phase of resuming from S3, after non-boot CPUs are brought
> back online.
> 
> Signed-off-by: David Stevens <stevensd@chromium.org>
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> Link: https://lore.kernel.org/r/20240424090341.72236-1-stevensd@chromium.org
> ---
>  kernel/irq/cpuhotplug.c | 11 ++++++++---
>  kernel/irq/manage.c     | 12 ++++++++----
>  2 files changed, 16 insertions(+), 7 deletions(-)

When forwarding patches on from others, you always have to sign off on
them :(

thanks,

greg k-h