From: Greg KH <gregkh@linuxfoundation.org>
To: Alex Deucher <alexdeucher@gmail.com>
Cc: Felix Kuehling <felix.kuehling@amd.com>,
amd-gfx@lists.freedesktop.org, stable@vger.kernel.org
Subject: Re: AMD drm patch workflow is broken for stable trees
Date: Thu, 15 Aug 2024 07:11:05 +0200 [thread overview]
Message-ID: <2024081558-filtrate-stuffed-db5b@gregkh> (raw)
In-Reply-To: <CADnq5_MXBZ_WykSMv-GtHZv60aNzvLFVBOvze09o6da3-4-dTQ@mail.gmail.com>
On Wed, Aug 14, 2024 at 05:30:08PM -0400, Alex Deucher wrote:
> On Wed, Aug 14, 2024 at 4:55 PM Felix Kuehling <felix.kuehling@amd.com> wrote:
> >
> > On 2024-08-12 11:00, Greg KH wrote:
> > > Hi all,
> > >
> > > As some of you have noticed, there's a TON of failure messages being
> > > sent out for AMD gpu driver commits that are tagged for stable
> > > backports. In short, you all are doing something really wrong with how
> > > you are tagging these.
> > Hi Greg,
> >
> > I got notifications about one KFD patch failing to apply on six branches
> > (6.10, 6.6, 6.1, 5.15, 5.10 and 5.4). The funny thing is, that you
> > already applied this patch on two branches back in May. The emails had a
> > suspicious looking date in the header (Sep 17, 2001). I wonder if there
> > was some date glitch that caused a whole bunch of patches to be re-sent
> > to stable somehow:
>
> I think the crux of the problem is that sometimes patches go into
> -next with stable tags and they end getting taken into -fixes as well
> so after the merge window they end up getting picked up for stable
> again. Going forward, if they land in -next, I'll cherry-pick -x the
> changes into -fixes so there is better traceability.
Please do so, and also work to not have duplicate commits like this in
different branches. Git can handle merges quite well, please use it.
If this shows up again in the next -rc1 merge window without any
changes, I'll have to just blackhole all amd drm patches going forward
until you all tell me you have fixed your development process.
thanks,
greg k-h
next prev parent reply other threads:[~2024-08-15 5:11 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-12 15:00 AMD drm patch workflow is broken for stable trees Greg KH
2024-08-14 20:39 ` Felix Kuehling
2024-08-14 21:30 ` Alex Deucher
2024-08-15 5:11 ` Greg KH [this message]
2024-08-23 21:23 ` Alex Deucher
2024-08-24 5:23 ` Greg KH
2024-08-27 14:18 ` Alex Deucher
2024-09-04 17:23 ` Greg KH
2024-09-30 14:10 ` Alex Deucher
2024-10-01 10:04 ` Greg KH
2024-10-01 13:19 ` Alex Deucher
2024-08-15 5:12 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2024081558-filtrate-stuffed-db5b@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=alexdeucher@gmail.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=felix.kuehling@amd.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox