From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.13]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5419B1A76B2 for ; Fri, 16 Aug 2024 15:42:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.13 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723822928; cv=none; b=VUv0vSChLMk603eg1erZEmIbe7vgt2aupKFhykvZ5h7aTG4ta+OMS4hikm67/g+0KmhSRg+4661xZN3lcUM25ts4lz9zfgVLBPjPpSCnubS3tqFcFOxGbvxrZ8Tdzx8dWmyQa1ZpBj2soraGUUHXlVZqO4Y7lNLLlbMi3Xh6st4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723822928; c=relaxed/simple; bh=3otU0mRE66w9lY1tYnQ55EuSyJxI0f8hfB3Nb1D7ku0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=eWsh7XGn0C77pAECyLrIlgalK7YOuFe5ql4SA/9pZwBehC255reM6gqTMKpgWCBBcR8+nwix1SDwMTxqrj7S3niMUPNa65+rv8rBE0yDxc1xRy6JxJU3ThswfnliL7m3JU4bbwby4ndIWM2kIizKmqP5T3VOQab0Fhn9MTpS1m0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=Ar/GbaQJ; arc=none smtp.client-ip=192.198.163.13 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="Ar/GbaQJ" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1723822926; x=1755358926; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=3otU0mRE66w9lY1tYnQ55EuSyJxI0f8hfB3Nb1D7ku0=; b=Ar/GbaQJAigWWAWmSHQUKPs5LMryqWRLU1OWZlav2RZLYviqBLSOes2w mgQdwFLlp8cNmqubh3VV5u46eOe0sVu8EaltzghF96Pk9cKIdGY3l7IFH NxR94xqtky5VSje8TH2MUGdcDpm+hQqZjSiGxD2IEgZryhcgEiJenBLUM RCyy7wzSe7mDaiPzBwIq62sohhfzEhbsGsDUZoL8AonPSg/pMmEhCFACQ +SYAAuLaSKXChXNMkx6Cb0s+M/I8LSB0R2dSbekK1tCX8xKWarn0ftUYo IfsQL6WB0uqKcJvd6jdr5oa+fQUg7sVRfIoC+3iH495SBS8b1EWIshQ95 w==; X-CSE-ConnectionGUID: E+5duTD4RL6C6OYHkkS35Q== X-CSE-MsgGUID: oXbGXQwWSyeS21E8yjWSIA== X-IronPort-AV: E=McAfee;i="6700,10204,11166"; a="25023937" X-IronPort-AV: E=Sophos;i="6.10,152,1719903600"; d="scan'208";a="25023937" Received: from fmviesa003.fm.intel.com ([10.60.135.143]) by fmvoesa107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Aug 2024 08:42:05 -0700 X-CSE-ConnectionGUID: 9DHqVNsdSXe5e3s1EXrVRA== X-CSE-MsgGUID: Ozma2omATDSBlJ2BvULWBQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.10,152,1719903600"; d="scan'208";a="63885201" Received: from lkp-server01.sh.intel.com (HELO 9a732dc145d3) ([10.239.97.150]) by fmviesa003.fm.intel.com with ESMTP; 16 Aug 2024 08:42:02 -0700 Received: from kbuild by 9a732dc145d3 with local (Exim 4.96) (envelope-from ) id 1sez5U-0006as-0n; Fri, 16 Aug 2024 15:42:00 +0000 Date: Fri, 16 Aug 2024 23:41:00 +0800 From: kernel test robot To: Zack Rusin , dri-devel@lists.freedesktop.org Cc: oe-kbuild-all@lists.linux.dev, Broadcom internal kernel review list , ian.forbes@broadcom.com, martin.krastev@broadcom.com, maaz.mombasawala@broadcom.com, Zack Rusin , stable@vger.kernel.org Subject: Re: [PATCH v3 2/2] drm/vmwgfx: Fix prime with external buffers Message-ID: <202408162343.umOPAMF9-lkp@intel.com> References: <20240815153404.630214-2-zack.rusin@broadcom.com> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240815153404.630214-2-zack.rusin@broadcom.com> Hi Zack, kernel test robot noticed the following build errors: [auto build test ERROR on drm/drm-next] [also build test ERROR on drm-intel/for-linux-next-fixes drm-misc/drm-misc-next drm-tip/drm-tip linus/master v6.11-rc3 next-20240816] [cannot apply to drm-exynos/exynos-drm-next drm-intel/for-linux-next] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Zack-Rusin/drm-vmwgfx-Fix-prime-with-external-buffers/20240815-234842 base: git://anongit.freedesktop.org/drm/drm drm-next patch link: https://lore.kernel.org/r/20240815153404.630214-2-zack.rusin%40broadcom.com patch subject: [PATCH v3 2/2] drm/vmwgfx: Fix prime with external buffers config: i386-allmodconfig (https://download.01.org/0day-ci/archive/20240816/202408162343.umOPAMF9-lkp@intel.com/config) compiler: gcc-12 (Debian 12.2.0-14) 12.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240816/202408162343.umOPAMF9-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202408162343.umOPAMF9-lkp@intel.com/ All errors (new ones prefixed by >>): drivers/gpu/drm/vmwgfx/vmwgfx_blit.c: In function 'vmw_external_bo_copy': >> drivers/gpu/drm/vmwgfx/vmwgfx_blit.c:503:25: error: implicit declaration of function 'floor' [-Werror=implicit-function-declaration] 503 | diff->rect.y1 = floor(dst_offset / dst_stride); | ^~~~~ cc1: some warnings being treated as errors vim +/floor +503 drivers/gpu/drm/vmwgfx/vmwgfx_blit.c 455 456 static int vmw_external_bo_copy(struct vmw_bo *dst, u32 dst_offset, 457 u32 dst_stride, struct vmw_bo *src, 458 u32 src_offset, u32 src_stride, 459 u32 width_in_bytes, u32 height, 460 struct vmw_diff_cpy *diff) 461 { 462 struct vmw_private *vmw = 463 container_of(dst->tbo.bdev, struct vmw_private, bdev); 464 size_t dst_size = dst->tbo.resource->size; 465 size_t src_size = src->tbo.resource->size; 466 struct iosys_map dst_map = {0}; 467 struct iosys_map src_map = {0}; 468 int ret, i; 469 u8 *vsrc; 470 u8 *vdst; 471 472 vsrc = map_external(src, &src_map); 473 if (!vsrc) { 474 drm_dbg_driver(&vmw->drm, "Wasn't able to map src\n"); 475 ret = -ENOMEM; 476 goto out; 477 } 478 479 vdst = map_external(dst, &dst_map); 480 if (!vdst) { 481 drm_dbg_driver(&vmw->drm, "Wasn't able to map dst\n"); 482 ret = -ENOMEM; 483 goto out; 484 } 485 486 vsrc += src_offset; 487 vdst += dst_offset; 488 if (src_stride == dst_stride) { 489 dst_size -= dst_offset; 490 src_size -= src_offset; 491 memcpy(vdst, vsrc, 492 min(dst_stride * height, min(dst_size, src_size))); 493 } else { 494 WARN_ON(dst_stride < width_in_bytes); 495 for (i = 0; i < height; ++i) { 496 memcpy(vdst, vsrc, width_in_bytes); 497 vsrc += src_stride; 498 vdst += dst_stride; 499 } 500 } 501 502 diff->rect.x1 = (dst_offset % dst_stride) / diff->cpp; > 503 diff->rect.y1 = floor(dst_offset / dst_stride); 504 diff->rect.x2 = diff->rect.x1 + width_in_bytes / diff->cpp; 505 diff->rect.y2 = diff->rect.y1 + height; 506 507 ret = 0; 508 out: 509 unmap_external(src, &src_map); 510 unmap_external(dst, &dst_map); 511 512 return ret; 513 } 514 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki