From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Bjorn Andersson <quic_bjorande@quicinc.com>
Cc: Sebastian Reichel <sre@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>,
Neil Armstrong <neil.armstrong@linaro.org>,
Johan Hovold <johan+linaro@kernel.org>,
Chris Lew <quic_clew@quicinc.com>,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
Stephen Boyd <swboyd@chromium.org>,
Amit Pundir <amit.pundir@linaro.org>,
linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
Johan Hovold <johan@kernel.org>,
stable@vger.kernel.org
Subject: Re: [PATCH 0/3] soc: qcom: pmic_glink: v6.11-rc bug fixes
Date: Mon, 19 Aug 2024 16:07:41 +0200 [thread overview]
Message-ID: <2024081914-exploit-yonder-4d51@gregkh> (raw)
In-Reply-To: <20240818-pmic-glink-v6-11-races-v1-0-f87c577e0bc9@quicinc.com>
On Sun, Aug 18, 2024 at 04:17:36PM -0700, Bjorn Andersson wrote:
> Amit and Johan both reported a NULL pointer dereference in the
> pmic_glink client code during initialization, and Stephen Boyd pointed
> out the problem (race condition).
>
> While investigating, and writing the fix, I noticed that
> ucsi_unregister() is called in atomic context but tries to sleep, and I
> also noticed that the condition for when to inform the pmic_glink client
> drivers when the remote has gone down is just wrong.
>
> So, let's fix all three.
>
> As mentioned in the commit message for the UCSI fix, I have a series in
> the works that makes the GLINK callback happen in a sleepable context,
> which would remove the need for the clients list to be protected by a
> spinlock, and removing the work scheduling. This is however not -rc
> material...
>
> In addition to the NULL pointer dereference, there is the -ECANCELED
> issue reported here:
> https://lore.kernel.org/all/Zqet8iInnDhnxkT9@hovoldconsulting.com/
> I have not yet been able to either reproduce this or convince myself
> that this is the same issue.
>
> Signed-off-by: Bjorn Andersson <quic_bjorande@quicinc.com>
What tree are these to go through? I can take them through mine, but if
someone else wants to, feel free to route them some other way.
thanks,
greg k-h
next prev parent reply other threads:[~2024-08-19 14:07 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-18 23:17 [PATCH 0/3] soc: qcom: pmic_glink: v6.11-rc bug fixes Bjorn Andersson
2024-08-18 23:17 ` [PATCH 1/3] soc: qcom: pmic_glink: Fix race during initialization Bjorn Andersson
2024-08-19 9:15 ` Neil Armstrong
2024-08-19 13:20 ` Heikki Krogerus
2024-08-18 23:17 ` [PATCH 2/3] usb: typec: ucsi: Move unregister out of atomic section Bjorn Andersson
2024-08-19 1:16 ` Dmitry Baryshkov
2024-08-19 3:05 ` Bjorn Andersson
2024-08-19 7:32 ` Dmitry Baryshkov
2024-08-19 9:16 ` Neil Armstrong
2024-08-19 13:27 ` Heikki Krogerus
2024-08-19 15:06 ` Johan Hovold
2024-08-19 16:45 ` Bjorn Andersson
2024-08-20 6:34 ` Johan Hovold
2024-08-19 15:33 ` Johan Hovold
2024-08-18 23:17 ` [PATCH 3/3] soc: qcom: pmic_glink: Actually communicate with remote goes down Bjorn Andersson
2024-08-19 1:09 ` Dmitry Baryshkov
2024-08-19 9:16 ` Neil Armstrong
2024-08-19 13:33 ` Heikki Krogerus
2024-08-19 10:12 ` [PATCH 0/3] soc: qcom: pmic_glink: v6.11-rc bug fixes Amit Pundir
2024-08-19 14:07 ` Greg Kroah-Hartman [this message]
2024-08-19 14:56 ` Bjorn Andersson
2024-08-19 15:48 ` Johan Hovold
2024-08-19 16:53 ` Bjorn Andersson
2024-08-20 7:31 ` Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2024081914-exploit-yonder-4d51@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=amit.pundir@linaro.org \
--cc=andersson@kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=johan+linaro@kernel.org \
--cc=johan@kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=quic_bjorande@quicinc.com \
--cc=quic_clew@quicinc.com \
--cc=sre@kernel.org \
--cc=stable@vger.kernel.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox