From: Sherry Yang <sherry.yang@oracle.com>
To: maxtram95@gmail.com
Cc: andrii@kernel.org, ast@kernel.org, daniel@iogearbox.net,
eddyz87@gmail.com, gregkh@linuxfoundation.org,
john.fastabend@gmail.com, maxim@isovalent.com, sashal@kernel.org,
stable@vger.kernel.org
Subject: BPF selftest failed to build
Date: Thu, 22 Aug 2024 18:45:14 -0700 [thread overview]
Message-ID: <20240823014514.3622865-1-sherry.yang@oracle.com> (raw)
In-Reply-To: <20240711184323.2355017-2-maxtram95@gmail.com>
Hi All,
We found BPF sefltest fail to build with following error:
08-09 20:39:59 DBG: |output|: progs/test_global_func10.c:24:1: error: unknown type name '__failure'
08-09 20:39:59 DBG: |output|: __failure __msg("invalid indirect access to stack")
08-09 20:39:59 DBG: |output|: ^
08-09 20:39:59 DBG: |output|: progs/test_global_func10.c:24:17: error: expected parameter declarator
08-09 20:39:59 DBG: |output|: __failure __msg("invalid indirect access to stack")
08-09 20:39:59 DBG: |output|: ^
08-09 20:39:59 DBG: |output|: progs/test_global_func10.c:24:17: error: expected ')'
08-09 20:39:59 DBG: |output|: progs/test_global_func10.c:24:16: note: to match this '('
08-09 20:39:59 DBG: |output|: __failure __msg("invalid indirect access to stack")
08-09 20:39:59 DBG: |output|: ^
08-09 20:39:59 DBG: |output|: progs/test_global_func10.c:24:52: error: expected ';' after top level declarator
08-09 20:39:59 DBG: |output|: __failure __msg("invalid indirect access to stack")
08-09 20:39:59 DBG: |output|: ^
08-09 20:39:59 DBG: |output|: ;
08-09 20:39:59 DBG: |output|: 4 errors generated.
08-09 20:39:59 DBG: |output|: make: *** [Makefile:470: /root/oltf/work/linux-bpf-qa/tools/testing/selftests/bpf/test_global_func10.o] Error 1
08-09 20:39:59 DBG: |output|: make: *** Waiting for unfinished jobs....
It happens from the commit e30bc19a9ee8("bpf: Allow reads from uninit stack"). We did a further look, '__failure' is defined in tools/testing/selftests/bpf/progs/bpf_misc.h, and was 1st introduced in commit 537c3f66eac1("selftests/bpf: add generic BPF program tester-loader") which is not backported to linux-5.15.y.
So we may need to revert the patch, or fix it.
Kind regards,
Sherry
next prev parent reply other threads:[~2024-08-23 1:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-11 18:43 [PATCH stable 5.10] bpf: Allow reads from uninit stack Maxim Mikityanskiy
2024-07-11 18:43 ` [PATCH stable 5.15] " Maxim Mikityanskiy
2024-08-23 1:45 ` Sherry Yang [this message]
2024-08-23 2:50 ` BPF selftest failed to build Shung-Hsi Yu
2024-08-27 12:44 ` Greg KH
2024-07-11 18:43 ` [PATCH stable 6.1] bpf: Allow reads from uninit stack Maxim Mikityanskiy
2024-07-15 12:09 ` [PATCH stable 5.10] " Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240823014514.3622865-1-sherry.yang@oracle.com \
--to=sherry.yang@oracle.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=daniel@iogearbox.net \
--cc=eddyz87@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=john.fastabend@gmail.com \
--cc=maxim@isovalent.com \
--cc=maxtram95@gmail.com \
--cc=sashal@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox