From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A0DE11C6887; Tue, 27 Aug 2024 15:11:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724771486; cv=none; b=mvtjkcYrltqpIIP+qwgIUztd9BndtTXSa+qNg+iJuVL/m4fNsrozroViglGGAtlbVNrxN//DZ2aJYLz2DHpMFy+zZyYwshNB04lfFnImXITnJggWuk6v3L1zBc7FhG2pVgZtX8HVcxL9uIESDce/cA95Ne7tMgUAd1lGLPHbmlQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724771486; c=relaxed/simple; bh=0zqNNx9vF94IOn2P5vfvfdsvKl53/dahCiGdHTpyPeY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=YRBrtpuI9jEareQAUjXAAbmZKqmGkkyl5+eCYJiaehoF6s6l+CRqhFL+UFTVd794rlsEvTPqzKwvMJXwP1aOkzmQu5pI/zcD3a/7Su8hzudlgpgFSJgaKJBxnk4VcIRggpRuzXCB6wDqzh6D25K7P5jQ30WFt7EEhHEzWECHFm8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=OOGKEjJk; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="OOGKEjJk" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C67E4C4DDEE; Tue, 27 Aug 2024 15:11:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1724771486; bh=0zqNNx9vF94IOn2P5vfvfdsvKl53/dahCiGdHTpyPeY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=OOGKEjJk8o4FuvNlInzyhYR9CCfPKCii9a8p0OpMtq2yPJ+/Csg9UzqGKxuN5j1ID 9jhckHPV+cG9UA0yKAvPsuBpWUo1mgB1Z7piEt4v9S2thnALgfpzqHOaSgJdAnTwKX ZbcDrdv+tN675UR3bc+SDei5lpgUjE3tpkg1XNsI= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Nikolay Aleksandrov , Hangbin Liu , Paolo Abeni , Sasha Levin Subject: [PATCH 6.10 171/273] bonding: fix xfrm state handling when clearing active slave Date: Tue, 27 Aug 2024 16:38:15 +0200 Message-ID: <20240827143839.915412147@linuxfoundation.org> X-Mailer: git-send-email 2.46.0 In-Reply-To: <20240827143833.371588371@linuxfoundation.org> References: <20240827143833.371588371@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Nikolay Aleksandrov [ Upstream commit c4c5c5d2ef40a9f67a9241dc5422eac9ffe19547 ] If the active slave is cleared manually the xfrm state is not flushed. This leads to xfrm add/del imbalance and adding the same state multiple times. For example when the device cannot handle anymore states we get: [ 1169.884811] bond0: (slave eni0np1): bond_ipsec_add_sa_all: failed to add SA because it's filled with the same state after multiple active slave clearings. This change also has a few nice side effects: user-space gets a notification for the change, the old device gets its mac address and promisc/mcast adjusted properly. Fixes: 18cb261afd7b ("bonding: support hardware encryption offload to slaves") Signed-off-by: Nikolay Aleksandrov Reviewed-by: Hangbin Liu Signed-off-by: Paolo Abeni Signed-off-by: Sasha Levin --- drivers/net/bonding/bond_options.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/bonding/bond_options.c b/drivers/net/bonding/bond_options.c index bc80fb6397dcd..95d59a18c0223 100644 --- a/drivers/net/bonding/bond_options.c +++ b/drivers/net/bonding/bond_options.c @@ -936,7 +936,7 @@ static int bond_option_active_slave_set(struct bonding *bond, /* check to see if we are clearing active */ if (!slave_dev) { netdev_dbg(bond->dev, "Clearing current active slave\n"); - RCU_INIT_POINTER(bond->curr_active_slave, NULL); + bond_change_active_slave(bond, NULL); bond_select_active_slave(bond); } else { struct slave *old_active = rtnl_dereference(bond->curr_active_slave); -- 2.43.0