From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4F7FD1A08A3; Tue, 27 Aug 2024 14:57:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724770634; cv=none; b=GSorHTfobkTwgkJA90Z15gsZnFYYIotEK9E+bP7Z2N3mCHEJo6TvjYoeskdBl2VSU15XJTXe3WhtdoZY7+Bin60OPEz0oBU/DqOm9sY784+pclvcPyw9QZkEj8FnnY4jti16Mv0GyqPTfZVXs6D8wBNFfmqOGzqt7DrCrrK53/A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724770634; c=relaxed/simple; bh=A3cCMo7ac5ydjSJleZI6CP/WmG8mHBDUTQ+xtkF7FRs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=tHLed4+VOF3jybHVpZYsBME9Zl2OI4bmEu+Y9Y5evnF/4R5dnFSZw7JxxrYXfuB9twq36GSGRqZHdkhMqfM7r+tSNGVQYlU6rwLWN2gsAftvpQIIaJgE9ZAuGp3TXxcR9aOuifCifggeuZEqI+hGQnxRHC5Ykr9vaGgx/xdxS/c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=HDgzDY4e; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="HDgzDY4e" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3E3EFC4FE80; Tue, 27 Aug 2024 14:57:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1724770633; bh=A3cCMo7ac5ydjSJleZI6CP/WmG8mHBDUTQ+xtkF7FRs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=HDgzDY4eWc7RDlkUpAC52+CACdPg1ZwgMdllhTZE3Dm49ral5oRNMXfzxfKjzs40m ljwRnV4etP1V8Zsw9EeKGqhH+UTXU7IaO084N1DQyoEzodK6C6x5acUtC55+g+Fpft 2/73vlp3JL2cGTSaClC9WkYrpQF4jVqp4sudScGY= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Nikolay Aleksandrov , Hangbin Liu , Paolo Abeni , Sasha Levin Subject: [PATCH 6.6 256/341] bonding: fix bond_ipsec_offload_ok return type Date: Tue, 27 Aug 2024 16:38:07 +0200 Message-ID: <20240827143853.149467453@linuxfoundation.org> X-Mailer: git-send-email 2.46.0 In-Reply-To: <20240827143843.399359062@linuxfoundation.org> References: <20240827143843.399359062@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.6-stable review patch. If anyone has any objections, please let me know. ------------------ From: Nikolay Aleksandrov [ Upstream commit fc59b9a5f7201b9f7272944596113a82cc7773d5 ] Fix the return type which should be bool. Fixes: 955b785ec6b3 ("bonding: fix suspicious RCU usage in bond_ipsec_offload_ok()") Signed-off-by: Nikolay Aleksandrov Reviewed-by: Hangbin Liu Signed-off-by: Paolo Abeni Signed-off-by: Sasha Levin --- drivers/net/bonding/bond_main.c | 18 ++++++------------ 1 file changed, 6 insertions(+), 12 deletions(-) diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c index 722ac5c4992c9..b4f8f5112edd5 100644 --- a/drivers/net/bonding/bond_main.c +++ b/drivers/net/bonding/bond_main.c @@ -599,34 +599,28 @@ static bool bond_ipsec_offload_ok(struct sk_buff *skb, struct xfrm_state *xs) struct net_device *real_dev; struct slave *curr_active; struct bonding *bond; - int err; + bool ok = false; bond = netdev_priv(bond_dev); rcu_read_lock(); curr_active = rcu_dereference(bond->curr_active_slave); real_dev = curr_active->dev; - if (BOND_MODE(bond) != BOND_MODE_ACTIVEBACKUP) { - err = false; + if (BOND_MODE(bond) != BOND_MODE_ACTIVEBACKUP) goto out; - } - if (!xs->xso.real_dev) { - err = false; + if (!xs->xso.real_dev) goto out; - } if (!real_dev->xfrmdev_ops || !real_dev->xfrmdev_ops->xdo_dev_offload_ok || - netif_is_bond_master(real_dev)) { - err = false; + netif_is_bond_master(real_dev)) goto out; - } - err = real_dev->xfrmdev_ops->xdo_dev_offload_ok(skb, xs); + ok = real_dev->xfrmdev_ops->xdo_dev_offload_ok(skb, xs); out: rcu_read_unlock(); - return err; + return ok; } static const struct xfrmdev_ops bond_xfrmdev_ops = { -- 2.43.0