From: Greg KH <gregkh@linuxfoundation.org>
To: Felix Kuehling <felix.kuehling@amd.com>
Cc: stable@vger.kernel.org, Alex Deucher <alexander.deucher@amd.com>
Subject: Re: [PATCH 5.15.y] drm/amdkfd: don't allow mapping the MMIO HDP page with large pages
Date: Fri, 30 Aug 2024 13:09:25 +0200 [thread overview]
Message-ID: <2024083002-lesser-surprise-d61b@gregkh> (raw)
In-Reply-To: <20240815194629.2074349-1-felix.kuehling@amd.com>
On Thu, Aug 15, 2024 at 03:46:29PM -0400, Felix Kuehling wrote:
> From: Alex Deucher <alexander.deucher@amd.com>
>
> We don't get the right offset in that case. The GPU has
> an unused 4K area of the register BAR space into which you can
> remap registers. We remap the HDP flush registers into this
> space to allow userspace (CPU or GPU) to flush the HDP when it
> updates VRAM. However, on systems with >4K pages, we end up
> exposing PAGE_SIZE of MMIO space.
>
> Fixes: d8e408a82704 ("drm/amdkfd: Expose HDP registers to user space")
> Reviewed-by: Felix Kuehling <felix.kuehling@amd.com>
> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
> Cc: stable@vger.kernel.org
> (cherry picked from commit 24e82654e98e96cece5d8b919c522054456eeec6)
Wrong git id, this should be be4a2a81b6b9 ("drm/amdkfd: don't allow
mapping the MMIO HDP page with large pages"), right?
{sigh}
prev parent reply other threads:[~2024-08-30 11:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-12 14:46 FAILED: patch "[PATCH] drm/amdkfd: don't allow mapping the MMIO HDP page with large" failed to apply to 5.15-stable tree gregkh
2024-08-15 19:46 ` [PATCH 5.15.y] drm/amdkfd: don't allow mapping the MMIO HDP page with large pages Felix Kuehling
2024-08-30 11:09 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2024083002-lesser-surprise-d61b@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=alexander.deucher@amd.com \
--cc=felix.kuehling@amd.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox