public inbox for stable@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Ariadne Conill <ariadne@ariadne.space>
Cc: stable@vger.kernel.org
Subject: Re: [PATCH] s390/pci: follow alloc_pages in dma_map_ops name change
Date: Sat, 31 Aug 2024 07:28:19 +0200	[thread overview]
Message-ID: <2024083155-impeach-harmony-034f@gregkh> (raw)
In-Reply-To: <20240830233023.20759-1-ariadne@ariadne.space>

On Fri, Aug 30, 2024 at 04:30:23PM -0700, Ariadne Conill wrote:
> In linux-6.6.y commit 983e6b2636f0099dbac1874c9e885bbe1cf2df05,
> alloc_pages was renamed to alloc_pages_op, but this was not changed for
> the s390 PCI implementation, most likely due to upstream changes in the
> s390 PCI implementation which moved it to using the generic IOMMU
> implementation after Linux 6.6 was released.
> 
> Signed-off-by: Ariadne Conill <ariadne@ariadne.space>
> ---
>  arch/s390/pci/pci_dma.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/s390/pci/pci_dma.c b/arch/s390/pci/pci_dma.c
> index 99209085c75b..ce0f2990cb04 100644
> --- a/arch/s390/pci/pci_dma.c
> +++ b/arch/s390/pci/pci_dma.c
> @@ -721,7 +721,7 @@ const struct dma_map_ops s390_pci_dma_ops = {
>  	.unmap_page	= s390_dma_unmap_pages,
>  	.mmap		= dma_common_mmap,
>  	.get_sgtable	= dma_common_get_sgtable,
> -	.alloc_pages	= dma_common_alloc_pages,
> +	.alloc_pages_op	= dma_common_alloc_pages,
>  	.free_pages	= dma_common_free_pages,
>  	/* dma_supported is unconditionally true without a callback */
>  };
> -- 
> 2.46.0
> 
> 

Thanks for the fix, but as per:
	https://lore.kernel.org/r/20240830221217.GA3837758@thelio-3990X
I'll just go revert the offending commit instead.

thanks,

greg k-h

      reply	other threads:[~2024-08-31  5:28 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-30 23:30 [PATCH] s390/pci: follow alloc_pages in dma_map_ops name change Ariadne Conill
2024-08-31  5:28 ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2024083155-impeach-harmony-034f@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=ariadne@ariadne.space \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox