Re: [PATCH v1 2/2] ufs: core: requeue MCQ abort request

[kernel test robot <lkp@intel.com>]

Hi,

kernel test robot noticed the following build errors:

[auto build test ERROR on jejb-scsi/for-next]
[also build test ERROR on mkp-scsi/for-next linus/master v6.11-rc5 next-20240830]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/peter-wang-mediatek-com/ufs-core-fix-the-issue-of-ICU-failure/20240830-154808
base:   https://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git for-next
patch link:    https://lore.kernel.org/r/20240830074426.21968-3-peter.wang%40mediatek.com
patch subject: [PATCH v1 2/2] ufs: core: requeue MCQ abort request
config: arm64-randconfig-r132-20240831 (https://download.01.org/0day-ci/archive/20240901/202409010304.Ivj4eQN6-lkp@intel.com/config)
compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project f28c006a5895fc0e329fe15fead81e37457cb1d1)
reproduce: (https://download.01.org/0day-ci/archive/20240901/202409010304.Ivj4eQN6-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202409010304.Ivj4eQN6-lkp@intel.com/

All errors (new ones prefixed by >>):

>> drivers/ufs/core/ufshcd.c:6505:6: error: implicit declaration of function 'is_mcq_enabled' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
           if (is_mcq_enabled(hba) && (*ret == 0))
               ^
   1 error generated.


vim +/is_mcq_enabled +6505 drivers/ufs/core/ufshcd.c

  6488	
  6489	static bool ufshcd_abort_one(struct request *rq, void *priv)
  6490	{
  6491		int *ret = priv;
  6492		u32 tag = rq->tag;
  6493		struct scsi_cmnd *cmd = blk_mq_rq_to_pdu(rq);
  6494		struct scsi_device *sdev = cmd->device;
  6495		struct Scsi_Host *shost = sdev->host;
  6496		struct ufs_hba *hba = shost_priv(shost);
  6497		struct ufshcd_lrb *lrbp = &hba->lrb[tag];
  6498	
  6499		*ret = ufshcd_try_to_abort_task(hba, tag);
  6500		dev_err(hba->dev, "Aborting tag %d / CDB %#02x %s\n", tag,
  6501			hba->lrb[tag].cmd ? hba->lrb[tag].cmd->cmnd[0] : -1,
  6502			*ret ? "failed" : "succeeded");
  6503	
  6504		/* Host will post to CQ with OCS_ABORTED after SQ clean up */
> 6505		if (is_mcq_enabled(hba) && (*ret == 0))
  6506			lrbp->host_initiate_abort = true;
  6507	
  6508		return *ret == 0;
  6509	}
  6510	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki