From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D15E344C97; Sun, 1 Sep 2024 16:19:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725207580; cv=none; b=n5xs124rOoNsfFJTfOFZThrCMWM9+HughLcQ1cjjBIb94vYlo3l3VxRtc//S+1azQWeQhlMw9RikIZ9nTK31Pnx1TtDHKMArv3YfwVhdcOh6qEzFyNk9iVTwHpnNPTLkj1VyNPOi+t0VJj5v0PKnSj75ENKm26mRbZ0ao+IwrqA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725207580; c=relaxed/simple; bh=ZzYcTgLyuo6aEIsTLYvMVubjQCiZQ/xqQFXT5EMRO4k=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Oge3mVWnGmALEfwt7ThRFfK1p1vfIy998Mpy6gI9aJ1Zog4Olscb15M3IEltk2BUmTcZH0C9CG3ijnjcUC84zghhEA7uqdPngyCcVwGZOUncYvrE4qhJDfKQNbR+CqtVYAlzG+hje6E7COKYYjv0faLbqK0G4qd2Tjd3eWigWlk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=EGc3ytK6; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="EGc3ytK6" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E0B77C4CEC3; Sun, 1 Sep 2024 16:19:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1725207580; bh=ZzYcTgLyuo6aEIsTLYvMVubjQCiZQ/xqQFXT5EMRO4k=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=EGc3ytK6XDSeBU/znnWbUqcgFqRQDHPQeEWELlMpolDrd35NWpkck/mykKE42St9Z 7caeLfj1lCVsgas3oxsbB2beJo7ulCz8DqAK+93+3Mo36NekN3fss+JlCB/x6GcMvc Pd+IdOJyc4sS3XXXKBUSENLDHA10wNAXKk8PZyys= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Dan Carpenter , "David S. Miller" , Sasha Levin Subject: [PATCH 4.19 15/98] atm: idt77252: prevent use after free in dequeue_rx() Date: Sun, 1 Sep 2024 18:15:45 +0200 Message-ID: <20240901160804.263274868@linuxfoundation.org> X-Mailer: git-send-email 2.46.0 In-Reply-To: <20240901160803.673617007@linuxfoundation.org> References: <20240901160803.673617007@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 4.19-stable review patch. If anyone has any objections, please let me know. ------------------ From: Dan Carpenter [ Upstream commit a9a18e8f770c9b0703dab93580d0b02e199a4c79 ] We can't dereference "skb" after calling vcc->push() because the skb is released. Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Signed-off-by: Dan Carpenter Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/atm/idt77252.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/atm/idt77252.c b/drivers/atm/idt77252.c index 36629633ae52a..c76792a471354 100644 --- a/drivers/atm/idt77252.c +++ b/drivers/atm/idt77252.c @@ -1117,8 +1117,8 @@ dequeue_rx(struct idt77252_dev *card, struct rsq_entry *rsqe) rpp->len += skb->len; if (stat & SAR_RSQE_EPDU) { + unsigned int len, truesize; unsigned char *l1l2; - unsigned int len; l1l2 = (unsigned char *) ((unsigned long) skb->data + skb->len - 6); @@ -1188,14 +1188,15 @@ dequeue_rx(struct idt77252_dev *card, struct rsq_entry *rsqe) ATM_SKB(skb)->vcc = vcc; __net_timestamp(skb); + truesize = skb->truesize; vcc->push(vcc, skb); atomic_inc(&vcc->stats->rx); - if (skb->truesize > SAR_FB_SIZE_3) + if (truesize > SAR_FB_SIZE_3) add_rx_skb(card, 3, SAR_FB_SIZE_3, 1); - else if (skb->truesize > SAR_FB_SIZE_2) + else if (truesize > SAR_FB_SIZE_2) add_rx_skb(card, 2, SAR_FB_SIZE_2, 1); - else if (skb->truesize > SAR_FB_SIZE_1) + else if (truesize > SAR_FB_SIZE_1) add_rx_skb(card, 1, SAR_FB_SIZE_1, 1); else add_rx_skb(card, 0, SAR_FB_SIZE_0, 1); -- 2.43.0