From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2C2F044C97; Sun, 1 Sep 2024 16:21:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725207685; cv=none; b=Ref6Eg7IQnnXJHaD1fMpPZd8xJhLBO44dAgukw8G+NhynOkULJE3in2wBK8Z8HLRyWWd0MWcLxdchn6c0V6RpywvDppsl09qZvTEegetrSuGsRe6B5RiiwQxt/Lne0taKgUrVftqygNEz6Q5+XOPPngidUmHmefzaeL5hMF9sFA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725207685; c=relaxed/simple; bh=R9SzzxvTuBA8Urh3YjhuZtkda8OyNem/K8kVdV3GPW8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=PGoZo70dFkzG9DjwgsfYQucNrklqcdL3AeMkmlvM0ol+4WEkwIoeRxqkvoh7djJeSvJ3B71D5KKWJd/nz5bM1wZBXNtJ/C7Kmj8AaOjo0z8NdUEyumMqCIfS/WsEpYyj+dNfWBkHQPLMzs/acxDomO2/SobhWziknFcAFS3McsY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=JHbtv+2T; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="JHbtv+2T" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8D081C4CEC3; Sun, 1 Sep 2024 16:21:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1725207685; bh=R9SzzxvTuBA8Urh3YjhuZtkda8OyNem/K8kVdV3GPW8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=JHbtv+2T+InLyQ9VU7KZxr1ARtGYdy7UObunj1k6z9BRorPfJTd40Nf07Af77NR6i YH7Qk5EPIFfxhbXi1SDXyVFE51FR6cVW99cQrhNO54HAF0Axa3Tfo9+9IZtrr+5CIL kDrnoxWVYiFffNVE+//Z9ObUMqGhCzhBDkYugtGQ= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Johan Hovold , Krishna Kurapati , Thinh Nguyen , Johan Hovold , Bjorn Andersson , Sasha Levin Subject: [PATCH 4.19 46/98] usb: dwc3: core: Skip setting event buffers for host only controllers Date: Sun, 1 Sep 2024 18:16:16 +0200 Message-ID: <20240901160805.436250084@linuxfoundation.org> X-Mailer: git-send-email 2.46.0 In-Reply-To: <20240901160803.673617007@linuxfoundation.org> References: <20240901160803.673617007@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 4.19-stable review patch. If anyone has any objections, please let me know. ------------------ From: Krishna Kurapati [ Upstream commit 89d7f962994604a3e3d480832788d06179abefc5 ] On some SoC's like SA8295P where the tertiary controller is host-only capable, GEVTADDRHI/LO, GEVTSIZ, GEVTCOUNT registers are not accessible. Trying to access them leads to a crash. For DRD/Peripheral supported controllers, event buffer setup is done again in gadget_pullup. Skip setup or cleanup of event buffers if controller is host-only capable. Suggested-by: Johan Hovold Signed-off-by: Krishna Kurapati Acked-by: Thinh Nguyen Reviewed-by: Johan Hovold Reviewed-by: Bjorn Andersson Tested-by: Johan Hovold Link: https://lore.kernel.org/r/20240420044901.884098-4-quic_kriskura@quicinc.com Signed-off-by: Greg Kroah-Hartman Signed-off-by: Sasha Levin --- drivers/usb/dwc3/core.c | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c index fd82904e14657..b14e06ee831bc 100644 --- a/drivers/usb/dwc3/core.c +++ b/drivers/usb/dwc3/core.c @@ -372,6 +372,13 @@ static void dwc3_free_event_buffers(struct dwc3 *dwc) static int dwc3_alloc_event_buffers(struct dwc3 *dwc, unsigned length) { struct dwc3_event_buffer *evt; + unsigned int hw_mode; + + hw_mode = DWC3_GHWPARAMS0_MODE(dwc->hwparams.hwparams0); + if (hw_mode == DWC3_GHWPARAMS0_MODE_HOST) { + dwc->ev_buf = NULL; + return 0; + } evt = dwc3_alloc_one_event_buffer(dwc, length); if (IS_ERR(evt)) { @@ -393,6 +400,9 @@ int dwc3_event_buffers_setup(struct dwc3 *dwc) { struct dwc3_event_buffer *evt; + if (!dwc->ev_buf) + return 0; + evt = dwc->ev_buf; evt->lpos = 0; dwc3_writel(dwc->regs, DWC3_GEVNTADRLO(0), @@ -410,6 +420,9 @@ void dwc3_event_buffers_cleanup(struct dwc3 *dwc) { struct dwc3_event_buffer *evt; + if (!dwc->ev_buf) + return; + evt = dwc->ev_buf; evt->lpos = 0; -- 2.43.0