From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8FB4E183CBC; Sun, 1 Sep 2024 16:21:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725207691; cv=none; b=Xvui4Oje93mA9aMF9A9tpvchKOs//hQdG5Un67OphuvnJIT9F9n+WZcuMz40Zx+t92Bq0XYLhM1lorqU6llZltoHPwFPVBjeO0Z7GtWYoQ2S+jr8gU0yCXWTRuf5VKvst2couMaRlhUJgTJk+H/NyJksv8d3kS7g+b3DLm2ZZec= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725207691; c=relaxed/simple; bh=CkG0/D/38YUg5Rfc8hWNtyeq+Mn/5vui02ah8N1u4Ws=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=JHRR1JURQM3xJfyaH0vsOSrEUL7lBp/0nU7XKDnKnHY3P2UYwPoXyGWQRcM9YhzCn0xkDZiJZuZiHxqy39ERN0APZM3XLjzyK+X/PstDM1TDjVduqUeRO5+Edl1PKMwDWf1Q77Q7y/7ok63Rj9K7rrS3ZuRA67B1+/RnD0nM044= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=KGeTmYcC; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="KGeTmYcC" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 11F10C4CEC3; Sun, 1 Sep 2024 16:21:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1725207691; bh=CkG0/D/38YUg5Rfc8hWNtyeq+Mn/5vui02ah8N1u4Ws=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=KGeTmYcChB8G4FI7VZvVpBOdTlx856mtrObO33nXgFOUdMbNsUa8y+EmcG6MnR8xQ ijet6Z235KNpnSosrhMaBmio1GC3MSLEhr2ojsNVRJjGbL9jtZDZvKHoHknB+KCvpk vkp2eAZfNA+0u8OSlcpfqW0Iw16hCzRDzkPri1sc= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Guanrui Huang , Thomas Gleixner , Zenghui Yu , Marc Zyngier , Sasha Levin Subject: [PATCH 4.19 48/98] irqchip/gic-v3-its: Remove BUG_ON in its_vpe_irq_domain_alloc Date: Sun, 1 Sep 2024 18:16:18 +0200 Message-ID: <20240901160805.511957221@linuxfoundation.org> X-Mailer: git-send-email 2.46.0 In-Reply-To: <20240901160803.673617007@linuxfoundation.org> References: <20240901160803.673617007@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 4.19-stable review patch. If anyone has any objections, please let me know. ------------------ From: Guanrui Huang [ Upstream commit 382d2ffe86efb1e2fa803d2cf17e5bfc34e574f3 ] This BUG_ON() is useless, because the same effect will be obtained by letting the code run its course and vm being dereferenced, triggering an exception. So just remove this check. Signed-off-by: Guanrui Huang Signed-off-by: Thomas Gleixner Reviewed-by: Zenghui Yu Acked-by: Marc Zyngier Link: https://lore.kernel.org/r/20240418061053.96803-3-guanrui.huang@linux.alibaba.com Signed-off-by: Sasha Levin --- drivers/irqchip/irq-gic-v3-its.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/irqchip/irq-gic-v3-its.c b/drivers/irqchip/irq-gic-v3-its.c index 6b58194c1e346..2e0478e8be747 100644 --- a/drivers/irqchip/irq-gic-v3-its.c +++ b/drivers/irqchip/irq-gic-v3-its.c @@ -2958,8 +2958,6 @@ static int its_vpe_irq_domain_alloc(struct irq_domain *domain, unsigned int virq struct page *vprop_page; int base, nr_ids, i, err = 0; - BUG_ON(!vm); - bitmap = its_lpi_alloc(roundup_pow_of_two(nr_irqs), &base, &nr_ids); if (!bitmap) return -ENOMEM; -- 2.43.0