From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A6853364AB; Sun, 1 Sep 2024 16:22:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725207744; cv=none; b=Wcb8Vt5sT+bl8ZfqRrwHhUsE/4pZLHSL8GqZdYlhh+aeSRfHs48bZ+aQUKnPigtlmxFlZvteH8ZTF5KMRZfQcpteH5gsKcidd+a5pdQl6IU13+O+MXUGIka8ta3nl/QU/1RZsDdrP555it5/Qyjo/8PUThV9vSAclQrFsgHlqrU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725207744; c=relaxed/simple; bh=u2kHE52fqksnO/SLxTzEZO92I2zeBMvlkW8yyB52ERY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=OEFagEB4ivvji8DGyJzFAAJ+1+ICxsrgB93KcDxFx4DD4UL39hMnJ7AwCTsZ+Uh/LbqP6jtzTgWLTtaYOwL0uTFwKy6CLVXX2B9/omwHzeLwGkPrLH/MG1kUvboCXd9m0yUNy71Ov3W/1oJc9j7Ivv9XynmqxWNPSIrKDlFx+wo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=l1JlOPNX; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="l1JlOPNX" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2C134C4CEC3; Sun, 1 Sep 2024 16:22:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1725207744; bh=u2kHE52fqksnO/SLxTzEZO92I2zeBMvlkW8yyB52ERY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=l1JlOPNX8jlGCiX6fjlJALOYL/iMuEvvhmmMJ8NkuBwo2V9S30OBMFlep6Peo6AV9 9Xh7tvzaYIPzdt+LAeaSlDaVViVYZzidUZ1ICswuvjEYFt7/dCf0otPumBL6VLR07N 7EcnrhLl6LJyShaOSxNoaTmnzA485q7e2VbEb6d0= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Jason Gerecke , Jiri Kosina Subject: [PATCH 4.19 65/98] HID: wacom: Defer calculation of resolution until resolution_code is known Date: Sun, 1 Sep 2024 18:16:35 +0200 Message-ID: <20240901160806.150597878@linuxfoundation.org> X-Mailer: git-send-email 2.46.0 In-Reply-To: <20240901160803.673617007@linuxfoundation.org> References: <20240901160803.673617007@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 4.19-stable review patch. If anyone has any objections, please let me know. ------------------ From: Jason Gerecke commit 1b8f9c1fb464968a5b18d3acc1da8c00bad24fad upstream. The Wacom driver maps the HID_DG_TWIST usage to ABS_Z (rather than ABS_RZ) for historic reasons. When the code to support twist was introduced in commit 50066a042da5 ("HID: wacom: generic: Add support for height, tilt, and twist usages"), we were careful to write it in such a way that it had HID calculate the resolution of the twist axis assuming ABS_RZ instead (so that we would get correct angular behavior). This was broken with the introduction of commit 08a46b4190d3 ("HID: wacom: Set a default resolution for older tablets"), which moved the resolution calculation to occur *before* the adjustment from ABS_Z to ABS_RZ occurred. This commit moves the calculation of resolution after the point that we are finished setting things up for its proper use. Signed-off-by: Jason Gerecke Fixes: 08a46b4190d3 ("HID: wacom: Set a default resolution for older tablets") Cc: stable@vger.kernel.org Signed-off-by: Jiri Kosina Signed-off-by: Greg Kroah-Hartman --- drivers/hid/wacom_wac.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) --- a/drivers/hid/wacom_wac.c +++ b/drivers/hid/wacom_wac.c @@ -1830,12 +1830,14 @@ static void wacom_map_usage(struct input int fmax = field->logical_maximum; unsigned int equivalent_usage = wacom_equivalent_usage(usage->hid); int resolution_code = code; - int resolution = hidinput_calc_abs_res(field, resolution_code); + int resolution; if (equivalent_usage == HID_DG_TWIST) { resolution_code = ABS_RZ; } + resolution = hidinput_calc_abs_res(field, resolution_code); + if (equivalent_usage == HID_GD_X) { fmin += features->offset_left; fmax -= features->offset_right;