Re: [PATCH v5.15-v5.10] drm/amd/pm: Fix the null pointer dereference for vega10_hwmgr

Greg KH
2024-09-08T12:59:51Z

On Fri, Sep 06, 2024 at 11:02:32AM -0400, Alex Deucher wrote:
> On Fri, Sep 6, 2024 at 4:50 AM Mukul Sikka <mukul.sikka@broadcom.com> wrote:
> >
> > On Fri, Sep 6, 2024 at 12:05 AM Alex Deucher <alexdeucher@gmail.com> wrote:
> > >
> > > On Tue, Sep 3, 2024 at 5:53 AM sikkamukul <mukul.sikka@broadcom.com> wrote:
> > > >
> > > > From: Bob Zhou <bob.zhou@amd.com>
> > > >
> > > > [ Upstream commit 50151b7f1c79a09117837eb95b76c2de76841dab ]
> > > >
> > > > Check return value and conduct null pointer handling to avoid null pointer dereference.
> > > >
> > > > Signed-off-by: Bob Zhou <bob.zhou@amd.com>
> > > > Reviewed-by: Tim Huang <Tim.Huang@amd.com>
> > > > Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
> > > > Signed-off-by: Sasha Levin <sashal@kernel.org>
> > > > Signed-off-by: Mukul Sikka <mukul.sikka@broadcom.com>
> > >
> > > Just out of curiosity, are you actually seeing an issue? This and a
> > > lot of the other recent NULL check patches are just static checker
> > > fixes. They don't actually fix a known issue.
> > >
> > No, according to the description of this patch and CVE-2024-43905.
> > It seems to be applicable to LTS.
>
> I don't know that this is really CVE material, but oh well. I'm not
> sure if it's actually possible to hit this in practice.

If it's not possible, there's no need to add the check.

thanks,

greg k-h