From: Andrew Morton <akpm@linux-foundation.org>
To: Yosry Ahmed <yosryahmed@google.com>
Cc: mm-commits@vger.kernel.org, stable@vger.kernel.org,
shakeel.butt@linux.dev, roman.gushchin@linux.dev,
nphamcs@gmail.com, muchun.song@linux.dev, mkoutny@suse.com,
mhocko@kernel.org, hannes@cmpxchg.org, me@yhndnzj.com
Subject: Re: [merged mm-hotfixes-stable] mm-memcontrol-respect-zswapwriteback-setting-from-parent-cg-too.patch removed from -mm tree
Date: Tue, 3 Sep 2024 12:53:29 -0700 [thread overview]
Message-ID: <20240903125329.726489169d81399a954f7787@linux-foundation.org> (raw)
In-Reply-To: <CAJD7tkYtM8gQDX8RrT1cnkfDQ0dRv4woNY4jrwjc1oUuavbuTg@mail.gmail.com>
On Tue, 3 Sep 2024 10:53:21 -0700 Yosry Ahmed <yosryahmed@google.com> wrote:
> > The inconsistency became more noticeable after I introduced the
> > MemoryZSwapWriteback= systemd unit setting [2] for controlling the knob.
> > The patch assumed that the kernel would enforce the value of parent
> > cgroups. It could probably be workarounded from systemd's side, by going
> > up the slice unit tree and inheriting the value. Yet I think it's more
> > sensible to make it behave consistently with zswap.max and friends.
> >
> > [1] https://wiki.archlinux.org/title/Power_management/Suspend_and_hibernate#Disable_zswap_writeback_to_use_the_swap_space_only_for_hibernation
> > [2] https://github.com/systemd/systemd/pull/31734
> >
> > Link: https://lkml.kernel.org/r/20240823162506.12117-1-me@yhndnzj.com
> > Fixes: 501a06fe8e4c ("zswap: memcontrol: implement zswap writeback disabling")
> > Signed-off-by: Mike Yuan <me@yhndnzj.com>
> > Reviewed-by: Nhat Pham <nphamcs@gmail.com>
> > Acked-by: Yosry Ahmed <yosryahmed@google.com>
>
> We wanted to CC stable here, it's too late at this point, right?
It has cc:stable?
> > Cc: Johannes Weiner <hannes@cmpxchg.org>
> > Cc: Michal Hocko <mhocko@kernel.org>
> > Cc: Michal Koutný <mkoutny@suse.com>
> > Cc: Muchun Song <muchun.song@linux.dev>
> > Cc: Roman Gushchin <roman.gushchin@linux.dev>
> > Cc: Shakeel Butt <shakeel.butt@linux.dev>
> > Cc: <stable@vger.kernel.org>
^^ here
next prev parent reply other threads:[~2024-09-03 19:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-02 0:59 [merged mm-hotfixes-stable] mm-memcontrol-respect-zswapwriteback-setting-from-parent-cg-too.patch removed from -mm tree Andrew Morton
2024-09-03 17:53 ` Yosry Ahmed
2024-09-03 19:53 ` Andrew Morton [this message]
2024-09-03 20:17 ` Yosry Ahmed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240903125329.726489169d81399a954f7787@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=me@yhndnzj.com \
--cc=mhocko@kernel.org \
--cc=mkoutny@suse.com \
--cc=mm-commits@vger.kernel.org \
--cc=muchun.song@linux.dev \
--cc=nphamcs@gmail.com \
--cc=roman.gushchin@linux.dev \
--cc=shakeel.butt@linux.dev \
--cc=stable@vger.kernel.org \
--cc=yosryahmed@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox