From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Cc: Benson Leung <bleung@chromium.org>,
Jameson Thies <jthies@google.com>,
Abhishek Pandit-Subedi <abhishekpandit@chromium.org>,
linux-usb@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH] usb: typec: ucsi: Fix cable registration
Date: Tue, 3 Sep 2024 10:06:59 +0200 [thread overview]
Message-ID: <2024090331-confiding-preflight-a260@gregkh> (raw)
In-Reply-To: <20240830130217.2155774-1-heikki.krogerus@linux.intel.com>
On Fri, Aug 30, 2024 at 04:02:17PM +0300, Heikki Krogerus wrote:
> The Cable PD Revision field in GET_CABLE_PROPERTY was
> introduced in UCSI v2.1, so adding check for that.
>
> The cable properties are also not used anywhere after the
> cable is registered, so removing the cable_prop member
> from struct ucsi_connector while at it.
>
> Fixes: 38ca416597b0 ("usb: typec: ucsi: Register cables based on GET_CABLE_PROPERTY")
> Cc: stable@vger.kernel.org
> Signed-off-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> ---
> drivers/usb/typec/ucsi/ucsi.c | 30 +++++++++++++++---------------
> drivers/usb/typec/ucsi/ucsi.h | 1 -
> 2 files changed, 15 insertions(+), 16 deletions(-)
This doesn't apply to my usb-linus branch at all:
checking file drivers/usb/typec/ucsi/ucsi.c
Hunk #1 succeeded at 965 (offset 54 lines).
Hunk #2 FAILED at 941.
Hunk #3 succeeded at 1203 (offset 52 lines).
1 out of 3 hunks FAILED
checking file drivers/usb/typec/ucsi/ucsi.h
Hunk #1 succeeded at 465 (offset 30 lines).
Can you rebase and resend?
thanks,
greg k-h
next prev parent reply other threads:[~2024-09-03 8:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-30 13:02 [PATCH] usb: typec: ucsi: Fix cable registration Heikki Krogerus
2024-09-03 8:06 ` Greg Kroah-Hartman [this message]
2024-09-03 11:58 ` Heikki Krogerus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2024090331-confiding-preflight-a260@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=abhishekpandit@chromium.org \
--cc=bleung@chromium.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=jthies@google.com \
--cc=linux-usb@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox