From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Cc: stable@vger.kernel.org, linux-usb@vger.kernel.org,
Charles Yo <charlesyo@google.com>, Kyle Tso <kyletso@google.com>,
Amit Sunil Dhamne <amitsd@google.com>,
Ondrej Jirman <megi@xff.cz>,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Subject: Re: [PATCH 6.6] usb: typec: fix up incorrectly backported "usb: typec: tcpm: unregister existing source caps before re-registration"
Date: Tue, 3 Sep 2024 09:02:47 +0200 [thread overview]
Message-ID: <2024090336-spider-skirmish-2ac9@gregkh> (raw)
In-Reply-To: <ZtVaaFD5wbmYlLCa@kuha.fi.intel.com>
On Mon, Sep 02, 2024 at 09:25:44AM +0300, Heikki Krogerus wrote:
> On Fri, Aug 30, 2024 at 04:00:09PM +0200, Greg Kroah-Hartman wrote:
> > In commit b16abab1fb64 ("usb: typec: tcpm: unregister existing source
> > caps before re-registration"), quilt, and git, applied the diff to the
> > incorrect function, which would cause bad problems if exercised in a
> > device with these capabilities.
> >
> > Fix this all up (including the follow-up fix in commit 04c05d50fa79
> > ("usb: typec: tcpm: fix use-after-free case in
> > tcpm_register_source_caps") to be in the correct function.
> >
> > Fixes: 04c05d50fa79 ("usb: typec: tcpm: fix use-after-free case in tcpm_register_source_caps")
> > Fixes: b16abab1fb64 ("usb: typec: tcpm: unregister existing source caps before re-registration")
> > Reported-by: Charles Yo <charlesyo@google.com>
> > Cc: Kyle Tso <kyletso@google.com>
> > Cc: Amit Sunil Dhamne <amitsd@google.com>
> > Cc: Ondrej Jirman <megi@xff.cz>
> > Cc: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> > Cc: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>
> Acked-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Thanks for the review!
prev parent reply other threads:[~2024-09-03 7:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-30 14:00 [PATCH 6.6] usb: typec: fix up incorrectly backported "usb: typec: tcpm: unregister existing source caps before re-registration" Greg Kroah-Hartman
2024-09-02 6:25 ` Heikki Krogerus
2024-09-03 7:02 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2024090336-spider-skirmish-2ac9@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=amitsd@google.com \
--cc=charlesyo@google.com \
--cc=dmitry.baryshkov@linaro.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=kyletso@google.com \
--cc=linux-usb@vger.kernel.org \
--cc=megi@xff.cz \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox