From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 630CE1494DB; Thu, 5 Sep 2024 10:03:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725530635; cv=none; b=o88WGsbIpsaTW1iZ1Hw6Z68QpsfXF2uWEu3e0ErjrMakk+vtO6YZvCWnCqowNKWElqgbREdaslNk7mpRdzvRe8/GJDoExgrHLiYRuBWCbYRd5RtnDJsrchktPvSPSSN5PLgtv4IrpWcHBRQd7KyvvF7PUxgGX0f2YAxRUIhXrkE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725530635; c=relaxed/simple; bh=D/s5bVSjqgFtkXX89Hh1hXUyU6UL5xm8FuAJBVqnkN8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=P99u+byCXruFmAieAayhOEkvJvBHmmM7dfzsqfHunW0/yPmgY9hjGQ+wL0aGyZYDF2VYIOYBTugWheirr8A4H959NRLQa5EOO6nAoWf7gkb0F6EES6icmNImFdOpQn5RhlL9bKjUvfo3EDOuaN/4LWUei1wKq0w0AcrWnFd+56o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=iPt+E7Kh; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="iPt+E7Kh" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D9E53C4CEC3; Thu, 5 Sep 2024 10:03:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1725530635; bh=D/s5bVSjqgFtkXX89Hh1hXUyU6UL5xm8FuAJBVqnkN8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=iPt+E7Kh2hhCLeWOL+dMGIJa4ICbJg4iTLpzWh/VMgneXrbarzwLF9Lw5lJ8bDeX6 HZsZvh+S+3TgBKABEVVyrKlve9qrWjfHq3TPrfa7t53JXwpzz3GDS85fJi3TkrzmfM nR9Y6O/PoMZZJ2Pk9J3Z2t0Qs5e/MchlSxE7fAT4= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Olivier Dautricourt , Vinod Koul , Sasha Levin Subject: [PATCH 6.1 085/101] dmaengine: altera-msgdma: properly free descriptor in msgdma_free_descriptor Date: Thu, 5 Sep 2024 11:41:57 +0200 Message-ID: <20240905093719.453791513@linuxfoundation.org> X-Mailer: git-send-email 2.46.0 In-Reply-To: <20240905093716.075835938@linuxfoundation.org> References: <20240905093716.075835938@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.1-stable review patch. If anyone has any objections, please let me know. ------------------ From: Olivier Dautricourt [ Upstream commit 54e4ada1a4206f878e345ae01cf37347d803d1b1 ] Remove list_del call in msgdma_chan_desc_cleanup, this should be the role of msgdma_free_descriptor. In consequence replace list_add_tail with list_move_tail in msgdma_free_descriptor. This fixes the path: msgdma_free_chan_resources -> msgdma_free_descriptors -> msgdma_free_desc_list -> msgdma_free_descriptor which does not correctly free the descriptors as first nodes were not removed from the list. Signed-off-by: Olivier Dautricourt Tested-by: Olivier Dautricourt Link: https://lore.kernel.org/r/20240608213216.25087-3-olivierdautricourt@gmail.com Signed-off-by: Vinod Koul Signed-off-by: Sasha Levin --- drivers/dma/altera-msgdma.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/dma/altera-msgdma.c b/drivers/dma/altera-msgdma.c index 8c479a3676fc..711e3756a39a 100644 --- a/drivers/dma/altera-msgdma.c +++ b/drivers/dma/altera-msgdma.c @@ -233,7 +233,7 @@ static void msgdma_free_descriptor(struct msgdma_device *mdev, struct msgdma_sw_desc *child, *next; mdev->desc_free_cnt++; - list_add_tail(&desc->node, &mdev->free_list); + list_move_tail(&desc->node, &mdev->free_list); list_for_each_entry_safe(child, next, &desc->tx_list, node) { mdev->desc_free_cnt++; list_move_tail(&child->node, &mdev->free_list); @@ -588,8 +588,6 @@ static void msgdma_chan_desc_cleanup(struct msgdma_device *mdev) list_for_each_entry_safe(desc, next, &mdev->done_list, node) { struct dmaengine_desc_callback cb; - list_del(&desc->node); - dmaengine_desc_get_callback(&desc->async_tx, &cb); if (dmaengine_desc_callback_valid(&cb)) { spin_unlock_irqrestore(&mdev->lock, irqflags); -- 2.43.0