From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9B680197A77; Thu, 5 Sep 2024 09:44:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725529480; cv=none; b=giVEBwMMHRan4V/lKRwT8fDeBdTTfX0d+p2xNwjU/otD8qg4Nki3VssguxUxzlZOI7SgvKzz84c9nQr1Bv5Zbchg+jZTQu5FJQlKi/Scho6l5xtG80wdU0JzaJmcHwepzCFBHBsc8Sz8J7rhdReZFf+2lkPpX9FuP+6+L3Vpz4M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725529480; c=relaxed/simple; bh=J7ug1Glgj5wuEKdkI5KVvHfXW8tW5R0X827DlLT4MWI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=rTKs8S7BHJwcjncxnijUMdoEYDFiVK22boklCrpwVE2MJrVSm24IlmCR7tdm+HqEJhlulyeAPvFqyM17Sjb1APcd9dSuFUn4aC+5knd+IzgrLhJ6Nyo/KoBU65T/A3ZIIzw+ioAmhF1pLLtemw/2YJNeb6Dh99j/6nLtgn2eeHg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=ltREeXoa; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="ltREeXoa" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 207E4C4CEC3; Thu, 5 Sep 2024 09:44:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1725529480; bh=J7ug1Glgj5wuEKdkI5KVvHfXW8tW5R0X827DlLT4MWI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ltREeXoahuylDFkGKsKJY67HZU6038DJGlCGAs4a7hFyK0+3h65t6wVlia6InuEEr v1kA5wCeaCfVNxTlMwki8HvToIDD9Hn48Yf1Ga1p1fmRtXKIMO/xzY1qrm0CDuEUIX chKEUwlym+syEzjzJS6BHP6LxqAMKPUivDg3KXZ4= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Ma Jun , Tim Huang , Alex Deucher , Sasha Levin Subject: [PATCH 6.10 046/184] drm/amdgpu/pm: Check the return value of smum_send_msg_to_smc Date: Thu, 5 Sep 2024 11:39:19 +0200 Message-ID: <20240905093734.046289763@linuxfoundation.org> X-Mailer: git-send-email 2.46.0 In-Reply-To: <20240905093732.239411633@linuxfoundation.org> References: <20240905093732.239411633@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Ma Jun [ Upstream commit 579f0c21baec9e7506b6bb3f60f0a9b6d07693b4 ] Check the return value of smum_send_msg_to_smc, otherwise we might use an uninitialized variable "now" Signed-off-by: Ma Jun Reviewed-by: Tim Huang Signed-off-by: Alex Deucher Signed-off-by: Sasha Levin --- drivers/gpu/drm/amd/pm/powerplay/hwmgr/smu10_hwmgr.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/smu10_hwmgr.c b/drivers/gpu/drm/amd/pm/powerplay/hwmgr/smu10_hwmgr.c index 02ba68d7c654..0b181bc8931c 100644 --- a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/smu10_hwmgr.c +++ b/drivers/gpu/drm/amd/pm/powerplay/hwmgr/smu10_hwmgr.c @@ -1036,7 +1036,9 @@ static int smu10_print_clock_levels(struct pp_hwmgr *hwmgr, switch (type) { case PP_SCLK: - smum_send_msg_to_smc(hwmgr, PPSMC_MSG_GetGfxclkFrequency, &now); + ret = smum_send_msg_to_smc(hwmgr, PPSMC_MSG_GetGfxclkFrequency, &now); + if (ret) + return ret; /* driver only know min/max gfx_clk, Add level 1 for all other gfx clks */ if (now == data->gfx_max_freq_limit/100) @@ -1057,7 +1059,9 @@ static int smu10_print_clock_levels(struct pp_hwmgr *hwmgr, i == 2 ? "*" : ""); break; case PP_MCLK: - smum_send_msg_to_smc(hwmgr, PPSMC_MSG_GetFclkFrequency, &now); + ret = smum_send_msg_to_smc(hwmgr, PPSMC_MSG_GetFclkFrequency, &now); + if (ret) + return ret; for (i = 0; i < mclk_table->count; i++) size += sprintf(buf + size, "%d: %uMhz %s\n", -- 2.43.0