From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E4C5318F2FF; Tue, 10 Sep 2024 10:00:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725962434; cv=none; b=OVGvSDcgZBlV33Dlsnm/TFQ6oRfLosh7lwPcY2mdhwtfHVlUgkHLIQ08HDDmaZpzwzdLBdQNQT1Xur+fSp4HxnyTHa60HKAdquvM56W5MER3GRMQRq1q3are636zuUF/hQgbKttQnCvwmVuMKq+leGh0J9v6QZKcJJi9De4YEm0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725962434; c=relaxed/simple; bh=0hdjV0FDvtEzE4fsRMlJQ4EfvbKgmWw4RZsHLGkDZTI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=uToxbNCTeV+Xho3KbJsTcpo4HZqAtl0k+ytzuSKcLP5SfUrp4SowT4vNfa2myaAr6TeplmUfn2GbGJCyp0fSdzvFzMnsgnEqXs8XkE6/mVf1rc5S6nuMdSb0H4LqSa+M2FN3pdpHReHjURZCWjur9GdJlmqdAtz8hG5XH+7GP3Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=ZW6S+lmg; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="ZW6S+lmg" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6D176C4CEC3; Tue, 10 Sep 2024 10:00:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1725962433; bh=0hdjV0FDvtEzE4fsRMlJQ4EfvbKgmWw4RZsHLGkDZTI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ZW6S+lmg4YR93XCC76NxuAU0UWSmbT0BrgCitveyv/UXrRfQ0DghtR+hKQ4RFtZQc cNkv938yocclIXX7SoM6dHIsYAUdgz7w+J9DpMNH3BVqlxuKSijBc7fLwbwzN4rwbe mdYzyJzNrdAhfE0pNhPpona8glZ+CEDbYnk7f6cY= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Harry Wentland , Tom Chung , Hersen Wu , Daniel Wheeler , Alex Deucher , Sasha Levin Subject: [PATCH 5.4 007/121] drm/amd/display: Stop amdgpu_dm initialize when stream nums greater than 6 Date: Tue, 10 Sep 2024 11:31:22 +0200 Message-ID: <20240910092546.088133392@linuxfoundation.org> X-Mailer: git-send-email 2.46.0 In-Reply-To: <20240910092545.737864202@linuxfoundation.org> References: <20240910092545.737864202@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Hersen Wu [ Upstream commit 84723eb6068c50610c5c0893980d230d7afa2105 ] [Why] Coverity reports OVERRUN warning. Should abort amdgpu_dm initialize. [How] Return failure to amdgpu_dm_init. Reviewed-by: Harry Wentland Acked-by: Tom Chung Signed-off-by: Hersen Wu Tested-by: Daniel Wheeler Signed-off-by: Alex Deucher Signed-off-by: Sasha Levin --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c index 3bfc4aa328c6..869b38908b28 100644 --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c @@ -2263,7 +2263,10 @@ static int amdgpu_dm_initialize_drm_device(struct amdgpu_device *adev) /* There is one primary plane per CRTC */ primary_planes = dm->dc->caps.max_streams; - ASSERT(primary_planes <= AMDGPU_MAX_PLANES); + if (primary_planes > AMDGPU_MAX_PLANES) { + DRM_ERROR("DM: Plane nums out of 6 planes\n"); + return -EINVAL; + } /* * Initialize primary planes, implicit planes for legacy IOCTLS. -- 2.43.0