From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7BE3F18C00C; Tue, 10 Sep 2024 10:01:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725962487; cv=none; b=GHDuPmaD26CG7uFuCvLEOG9y0uNwDE9OXPgDGU4IqjppIwar5K+F0RvxmQPwfvyNW5ZMvBPTa0HpzCvhwNOS+EE6nnK9VxadwVRDHBgfl1lH/TI98hkSN88iXS8FoMi3M+8p/+Q72nL1bV/F/Y/nV6+aT1cveOd7QH0khBMO+xc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725962487; c=relaxed/simple; bh=JA6xyiuZXFrI8+4tSaMQSWo5PmRuqOQzg3qi1dUnsGg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=cW7rZ5qIsRi9rv1NaPXlyV1cZzWyfXBvKJvXIPNDoFi2a8aRE5ecI10Z/cvk2/AMHesil+p8T9UAm7GnybQ7cMHJPNaLsHI99ZXOABzGm+gl82gjdYxsdoMjodfY2afWunyCS1Sn2ZSjBQEiDUSAp4JtFcOX5JV5bNDFUX6SZHE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=eEUf99W+; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="eEUf99W+" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A74A2C4CEC3; Tue, 10 Sep 2024 10:01:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1725962487; bh=JA6xyiuZXFrI8+4tSaMQSWo5PmRuqOQzg3qi1dUnsGg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=eEUf99W+cowYJmAS6sg3tN2yWsHIRpcp8qM+tuUh9de5v3JnEbqV+SK7xxSuScSXc l/99TTcYnGpEf5ds6T/kSUkl0T78eCfGEIhrytPFWSw4HkFE7Z6JfkOijxqwxKFP7W gY/OucGPgB5aRzt+YvfTF1yX3aUVHbd2W32oAj6Q= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Shantanu Goel , Oliver Neukum , Sasha Levin Subject: [PATCH 5.4 050/121] usb: uas: set host status byte on data completion error Date: Tue, 10 Sep 2024 11:32:05 +0200 Message-ID: <20240910092548.140774259@linuxfoundation.org> X-Mailer: git-send-email 2.46.0 In-Reply-To: <20240910092545.737864202@linuxfoundation.org> References: <20240910092545.737864202@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Shantanu Goel [ Upstream commit 9d32685a251a754f1823d287df233716aa23bcb9 ] Set the host status byte when a data completion error is encountered otherwise the upper layer may end up using the invalid zero'ed data. The following output was observed from scsi/sd.c prior to this fix. [ 11.872824] sd 0:0:0:1: [sdf] tag#9 data cmplt err -75 uas-tag 1 inflight: [ 11.872826] sd 0:0:0:1: [sdf] tag#9 CDB: Read capacity(16) 9e 10 00 00 00 00 00 00 00 00 00 00 00 20 00 00 [ 11.872830] sd 0:0:0:1: [sdf] Sector size 0 reported, assuming 512. Signed-off-by: Shantanu Goel Acked-by: Oliver Neukum Link: https://lore.kernel.org/r/87msnx4ec6.fsf@yahoo.com Signed-off-by: Greg Kroah-Hartman Signed-off-by: Sasha Levin --- drivers/usb/storage/uas.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/storage/uas.c b/drivers/usb/storage/uas.c index 678903d1ce4d..7493b4d9d1f5 100644 --- a/drivers/usb/storage/uas.c +++ b/drivers/usb/storage/uas.c @@ -424,6 +424,7 @@ static void uas_data_cmplt(struct urb *urb) uas_log_cmd_state(cmnd, "data cmplt err", status); /* error: no data transfered */ scsi_set_resid(cmnd, sdb->length); + set_host_byte(cmnd, DID_ERROR); } else { scsi_set_resid(cmnd, sdb->length - urb->actual_length); } -- 2.43.0