From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1FC9218C91B; Tue, 10 Sep 2024 10:05:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725962708; cv=none; b=p1VtywDfVqehhut2wUMJCB5B6Kd8xlp9Gysh9Wu/0r4j/fcYTB130SCb64jfpYN4rwvxtW0GWjA3clAcifOz34zctjgO3Apprt5ju4NEXZGeirEJjBIRHu8LnOmMHTa58wHTjrO9TK9n5xxeCBLnKBcE3T0FR5r9hMrOIpo6U7s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725962708; c=relaxed/simple; bh=lX9Fn67jE+Tn8Bbdx1lUR5YaynhTy6+hthx8SpvOmYI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=pFUMeHrFpIfOsYWSn+Df18mCiYba6EA2stoDMWyFXV3OaZuaXuaryjWVtMNrt32nVvYDUtjkxNojLqx+dDR9M3+LlimUJeZAVkk4Lasg15nlRqmGJcsht6ILKQkiLuCgEDYvvuAay1lwmEAFBF2y0oit526GSaj0vM9+sQXigZQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=1fVHe6JU; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="1fVHe6JU" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5F1ECC4CEC3; Tue, 10 Sep 2024 10:05:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1725962707; bh=lX9Fn67jE+Tn8Bbdx1lUR5YaynhTy6+hthx8SpvOmYI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=1fVHe6JUAlV5JS+ZbXc7H9Uq0kjiZjs7PuudGOOaK7AGmOKeGG7/xeCCuRyGB4l2U IEJ/2LG62BCW+jkVhi0o1SRenis40A4lVAup6R43tziySqSVfijRqvj1LQWWVJtN16 oytrI+oXT9DCqx93PvNpwd3RGDb1QzCqcDcqJKNA= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, syzbot+24c0361074799d02c452@syzkaller.appspotmail.com, Camila Alvarez , Silvan Jegen , Jiri Kosina , Sasha Levin Subject: [PATCH 5.4 087/121] HID: cougar: fix slab-out-of-bounds Read in cougar_report_fixup Date: Tue, 10 Sep 2024 11:32:42 +0200 Message-ID: <20240910092550.005086776@linuxfoundation.org> X-Mailer: git-send-email 2.46.0 In-Reply-To: <20240910092545.737864202@linuxfoundation.org> References: <20240910092545.737864202@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Camila Alvarez [ Upstream commit a6e9c391d45b5865b61e569146304cff72821a5d ] report_fixup for the Cougar 500k Gaming Keyboard was not verifying that the report descriptor size was correct before accessing it Reported-by: syzbot+24c0361074799d02c452@syzkaller.appspotmail.com Closes: https://syzkaller.appspot.com/bug?extid=24c0361074799d02c452 Signed-off-by: Camila Alvarez Reviewed-by: Silvan Jegen Signed-off-by: Jiri Kosina Signed-off-by: Sasha Levin --- drivers/hid/hid-cougar.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/hid/hid-cougar.c b/drivers/hid/hid-cougar.c index 4ff3bc1d25e2..5294299afb26 100644 --- a/drivers/hid/hid-cougar.c +++ b/drivers/hid/hid-cougar.c @@ -106,7 +106,7 @@ static void cougar_fix_g6_mapping(void) static __u8 *cougar_report_fixup(struct hid_device *hdev, __u8 *rdesc, unsigned int *rsize) { - if (rdesc[2] == 0x09 && rdesc[3] == 0x02 && + if (*rsize >= 117 && rdesc[2] == 0x09 && rdesc[3] == 0x02 && (rdesc[115] | rdesc[116] << 8) >= HID_MAX_USAGES) { hid_info(hdev, "usage count exceeds max: fixing up report descriptor\n"); -- 2.43.0