From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6EDDB18EFCE; Tue, 10 Sep 2024 10:39:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725964759; cv=none; b=hgAdHWNRXor6wbraMYHiR+3r151H3t0sVOaipsVxtQkbQci7BIBhAT9enaWuusYU7fOgTGZsN9zdEJhAt5qZlj66FgCNFG+0giFrouPp56jY4N/DqA7L4Q9EAmiERiSwiXJ1Rndxin7Ql6Y/0vU8oi7eeyDin57siuzER898e28= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725964759; c=relaxed/simple; bh=Qc4OmfedfFr82GP7wMIz/fFmC6vViCPlI7amAtCpZnc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=XRLKWldEZl4f/HwU4s+8qDKu1HfSRrA5hZ2KrDsGiLIMRMu/W4MjG59DBIHDVe/+JjcUExK958zcB6psuqFj1ZI1A2MUlfBNYEy3L+w98Dc6J7xytwlsZC63/gXeQXYvlPAnMtn3y6pbHgsIYtMvITaP2y9QVvl2EwATXIyrdlw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=ybtcFo/j; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="ybtcFo/j" Received: by smtp.kernel.org (Postfix) with ESMTPSA id EA16EC4CEC6; Tue, 10 Sep 2024 10:39:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1725964759; bh=Qc4OmfedfFr82GP7wMIz/fFmC6vViCPlI7amAtCpZnc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ybtcFo/jpytBfHu3n0R+USNS6M2kBHKr4PKKgHKojx+hMeTTg740suflQ/xcxhbBi +95LApoGlCvJyS5TfydDdi4YUcIla6PbpSa5P5cEUQHsE4X8aUyKjDZBll+2/Qz7Fe 1EbV64Kw+Flmw9zpY/Qsv2n3OXwLyoJy1A14Hutc= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Ma Jun , Alex Deucher , Yang Wang , Sasha Levin Subject: [PATCH 5.10 021/186] drm/amdgpu/pm: Fix uninitialized variable agc_btc_response Date: Tue, 10 Sep 2024 11:31:56 +0200 Message-ID: <20240910092555.505450069@linuxfoundation.org> X-Mailer: git-send-email 2.46.0 In-Reply-To: <20240910092554.645718780@linuxfoundation.org> References: <20240910092554.645718780@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Ma Jun [ Upstream commit df4409d8a04dd39d7f2aa0c5f528a56b99eaaa13 ] Assign an default value to agc_btc_response in failed case Signed-off-by: Ma Jun Acked-by: Alex Deucher Reviewed-by: Yang Wang Signed-off-by: Alex Deucher Signed-off-by: Sasha Levin --- drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega10_hwmgr.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega10_hwmgr.c b/drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega10_hwmgr.c index 91fefaeaf47d..1b1603101d7d 100644 --- a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega10_hwmgr.c +++ b/drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega10_hwmgr.c @@ -2361,15 +2361,20 @@ static int vega10_acg_enable(struct pp_hwmgr *hwmgr) { struct vega10_hwmgr *data = hwmgr->backend; uint32_t agc_btc_response; + int ret; if (data->smu_features[GNLD_ACG].supported) { if (0 == vega10_enable_smc_features(hwmgr, true, data->smu_features[GNLD_DPM_PREFETCHER].smu_feature_bitmap)) data->smu_features[GNLD_DPM_PREFETCHER].enabled = true; - smum_send_msg_to_smc(hwmgr, PPSMC_MSG_InitializeAcg, NULL); + ret = smum_send_msg_to_smc(hwmgr, PPSMC_MSG_InitializeAcg, NULL); + if (ret) + return ret; - smum_send_msg_to_smc(hwmgr, PPSMC_MSG_RunAcgBtc, &agc_btc_response); + ret = smum_send_msg_to_smc(hwmgr, PPSMC_MSG_RunAcgBtc, &agc_btc_response); + if (ret) + agc_btc_response = 0; if (1 == agc_btc_response) { if (1 == data->acg_loop_state) -- 2.43.0