From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D34AF184549; Tue, 10 Sep 2024 10:36:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725964575; cv=none; b=MDdieg1gX2Cbv9QRc0cAMJWSTrK3QN8pGbDoROQlo0ROnJQPotLfiaofNHVCZqumDLXwYqVQ21tFvP3PaW6gnZZfXU3CEry/I7YajxIJwm4BDfD0CNPX0g5nzy2SjP61qsvXQMugEi38rd78foGHyOR4Rn955XDuuk+LgAOmmt4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725964575; c=relaxed/simple; bh=v0fLRZsmZA7qFvXnS6bDV6j+QJ4bXKffeqZUrUAPhOY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=KBMXPRJXbtnv3eRq38y/oeZsvw3teLV2aDYrEA/pekLH05UIhN1pbNw44l87Okut0d+voo8/vJsBBoHswiX6KW6LGn14DkH7omU0kSOPUN+z7FM1I+Uh5CKcnFSkti3tG6zEs1Rlc9cbBITjovr1FKkjRSto5PVznbFIQ01IXl8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=R/yMAf1d; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="R/yMAf1d" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 57FD6C4CEC3; Tue, 10 Sep 2024 10:36:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1725964575; bh=v0fLRZsmZA7qFvXnS6bDV6j+QJ4bXKffeqZUrUAPhOY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=R/yMAf1dZA5v0hQ36ms6ba7BrzoGDG5VtRDSjCFhwXgZ0B4cmOYzV8AkrHyvO2lW8 KZop+ZV6ony5C7UbGYsqfWS3Bb34sEwnP0ftqh5IMpcJ05ADcjhJIRcaZg/gxzp2n2 jaEWN8KN47z1lSviduFC1EQNJ1hFD91vZ3sy0470= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, "Rafael J. Wysocki" , "Rafael J. Wysocki" , Gavin Shan , Jonathan Cameron , Catalin Marinas , Sasha Levin Subject: [PATCH 6.6 229/269] ACPI: processor: Return an error if acpi_processor_get_info() fails in processor_add() Date: Tue, 10 Sep 2024 11:33:36 +0200 Message-ID: <20240910092616.086231039@linuxfoundation.org> X-Mailer: git-send-email 2.46.0 In-Reply-To: <20240910092608.225137854@linuxfoundation.org> References: <20240910092608.225137854@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.6-stable review patch. If anyone has any objections, please let me know. ------------------ From: Jonathan Cameron [ Upstream commit fadf231f0a06a6748a7fc4a2c29ac9ef7bca6bfd ] Rafael observed [1] that returning 0 from processor_add() will result in acpi_default_enumeration() being called which will attempt to create a platform device, but that makes little sense when the processor is known to be not available. So just return the error code from acpi_processor_get_info() instead. Link: https://lore.kernel.org/all/CAJZ5v0iKU8ra9jR+EmgxbuNm=Uwx2m1-8vn_RAZ+aCiUVLe3Pw@mail.gmail.com/ [1] Suggested-by: Rafael J. Wysocki Acked-by: Rafael J. Wysocki Reviewed-by: Gavin Shan Signed-off-by: Jonathan Cameron Link: https://lore.kernel.org/r/20240529133446.28446-5-Jonathan.Cameron@huawei.com Signed-off-by: Catalin Marinas Signed-off-by: Sasha Levin --- drivers/acpi/acpi_processor.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/acpi/acpi_processor.c b/drivers/acpi/acpi_processor.c index 0f5218e361df..5f760bc62219 100644 --- a/drivers/acpi/acpi_processor.c +++ b/drivers/acpi/acpi_processor.c @@ -415,7 +415,7 @@ static int acpi_processor_add(struct acpi_device *device, result = acpi_processor_get_info(device); if (result) /* Processor is not physically present or unavailable */ - return 0; + return result; BUG_ON(pr->id >= nr_cpu_ids); -- 2.43.0