From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C701418C002; Tue, 10 Sep 2024 09:42:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725961370; cv=none; b=qyQIUBz2r87iEFmPfhnG9NAKSt83pjJTXMqPEmjK2CT4EUNFJ6PKZmyEFEVYUALFk8Df27q+/0ITPrC6c37HdwG8Jvk4LzdqQtYZUU84JLeAC37gPZbmLpEq4xV50mwEWkBir1OtEaEbrlQUT6NuPjyi9LcyWRpYVkFVY8RelEc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725961370; c=relaxed/simple; bh=iaHaBDpqPqGd8oRh9YlXu/AszKObxiVWlUQmA89zXec=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Jtmyvyu3vLsbtKAFKQJd4avP3vIpayaIhyr5Y5JidHzBAT+EgAYT3zVfqeO6o+vEZdmK2zrLLs5NkI68VwyBIY1nKyoFj4rMLuToXPBnI3Hk8iObQu6tWGZNeNrUyntbC7iIGwVyjdB2DYW2BzIH3xBAl9k74Mw4cJbO+xAU7uI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=NPI+NDKb; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="NPI+NDKb" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2755EC4CEC3; Tue, 10 Sep 2024 09:42:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1725961370; bh=iaHaBDpqPqGd8oRh9YlXu/AszKObxiVWlUQmA89zXec=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=NPI+NDKbNxw6HA9v/c4ttZ1AEi1RR5EMnONbS0yrg30+41bZWS8O8NzWAT7sMdiFZ tJqUq/K0CiVKlkGqGiM7YHDdtFU7o6MQuWiUtwiuoMISbOhr8IZRj41y9rOzTFrvOS OS4InijEs6fCq1PXE8ra2/UzY6tkA9HqokOU45/c= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Dan Carpenter , Namjae Jeon , Steve French Subject: [PATCH 6.10 019/375] ksmbd: Unlock on in ksmbd_tcp_set_interfaces() Date: Tue, 10 Sep 2024 11:26:56 +0200 Message-ID: <20240910092622.916041872@linuxfoundation.org> X-Mailer: git-send-email 2.46.0 In-Reply-To: <20240910092622.245959861@linuxfoundation.org> References: <20240910092622.245959861@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Dan Carpenter commit 844436e045ac2ab7895d8b281cb784a24de1d14d upstream. Unlock before returning an error code if this allocation fails. Fixes: 0626e6641f6b ("cifsd: add server handler for central processing and tranport layers") Cc: stable@vger.kernel.org # v5.15+ Signed-off-by: Dan Carpenter Acked-by: Namjae Jeon Signed-off-by: Steve French Signed-off-by: Greg Kroah-Hartman --- fs/smb/server/transport_tcp.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) --- a/fs/smb/server/transport_tcp.c +++ b/fs/smb/server/transport_tcp.c @@ -624,8 +624,10 @@ int ksmbd_tcp_set_interfaces(char *ifc_l for_each_netdev(&init_net, netdev) { if (netif_is_bridge_port(netdev)) continue; - if (!alloc_iface(kstrdup(netdev->name, GFP_KERNEL))) + if (!alloc_iface(kstrdup(netdev->name, GFP_KERNEL))) { + rtnl_unlock(); return -ENOMEM; + } } rtnl_unlock(); bind_additional_ifaces = 1;