From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6359B178CDE; Tue, 10 Sep 2024 09:46:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725961576; cv=none; b=e3DDExX56/391xNNtktEG6D0U4sjhijNA5fcVgcwrI+hNNattqyxIikk8BfVWwnkXuXlhULyI3wkBTXzI87obHBz9J+q3GUVimM0ty0GkvweRp1OnKRkype6dKDnattbQtHxuu2TEvq27fvugtGBLvxu/jcVRKz4j+3sJw/gJtU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725961576; c=relaxed/simple; bh=4K5bpU9kyhwxCAopkVfydib/OW/OGQfCYDzK1MOlk0s=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=W5wp7gwWX22cE2EW2XwNk8WWZazZ0VVtm1dqTG0jmVBUmzfqM153c7gpialRMGmwP5bsH9CqUAsOnmU8jBIGMi6oVmNKttK+YIkAG2+0FPITjnGCJNkXjQ/di+aZUjCJi2t6vVxGH8xzM8Q7OffzC0BM5jCHzOhPC4g2MeQuEcs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=e5UXo4Db; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="e5UXo4Db" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E0319C4CECE; Tue, 10 Sep 2024 09:46:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1725961576; bh=4K5bpU9kyhwxCAopkVfydib/OW/OGQfCYDzK1MOlk0s=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=e5UXo4Db0vlBK2Dqs+KnuMnO+GJg7Och0aVgdO78u7xcymnQyUvofddZZ1S6WSCJK wXm3tPLsZcha+tiigA4M7eJZtt1MXtiCqb4bMek5yUHnfMTSwTzvsSvlgaeiRWFxIS hYva180b+ClMjY0YoeheYJmq2YegIlwSkFoEa/Nc= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Andy Shevchenko , Lee Jones , Sasha Levin Subject: [PATCH 6.10 117/375] leds: spi-byte: Call of_node_put() on error path Date: Tue, 10 Sep 2024 11:28:34 +0200 Message-ID: <20240910092626.354687052@linuxfoundation.org> X-Mailer: git-send-email 2.46.0 In-Reply-To: <20240910092622.245959861@linuxfoundation.org> References: <20240910092622.245959861@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Andy Shevchenko [ Upstream commit 7f9ab862e05c5bc755f65bf6db7edcffb3b49dfc ] Add a missing call to of_node_put(np) on error. Signed-off-by: Andy Shevchenko Link: https://lore.kernel.org/r/20240606173037.3091598-2-andriy.shevchenko@linux.intel.com Signed-off-by: Lee Jones Signed-off-by: Sasha Levin --- drivers/leds/leds-spi-byte.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/leds/leds-spi-byte.c b/drivers/leds/leds-spi-byte.c index 96296db5f410..b04cf502e603 100644 --- a/drivers/leds/leds-spi-byte.c +++ b/drivers/leds/leds-spi-byte.c @@ -91,7 +91,6 @@ static int spi_byte_probe(struct spi_device *spi) dev_err(dev, "Device must have exactly one LED sub-node."); return -EINVAL; } - child = of_get_next_available_child(dev_of_node(dev), NULL); led = devm_kzalloc(dev, sizeof(*led), GFP_KERNEL); if (!led) @@ -104,11 +103,13 @@ static int spi_byte_probe(struct spi_device *spi) led->ldev.max_brightness = led->cdef->max_value - led->cdef->off_value; led->ldev.brightness_set_blocking = spi_byte_brightness_set_blocking; + child = of_get_next_available_child(dev_of_node(dev), NULL); state = of_get_property(child, "default-state", NULL); if (state) { if (!strcmp(state, "on")) { led->ldev.brightness = led->ldev.max_brightness; } else if (strcmp(state, "off")) { + of_node_put(child); /* all other cases except "off" */ dev_err(dev, "default-state can only be 'on' or 'off'"); return -EINVAL; @@ -123,9 +124,12 @@ static int spi_byte_probe(struct spi_device *spi) ret = devm_led_classdev_register_ext(&spi->dev, &led->ldev, &init_data); if (ret) { + of_node_put(child); mutex_destroy(&led->mutex); return ret; } + + of_node_put(child); spi_set_drvdata(spi, led); return 0; -- 2.43.0