From: Greg KH <gregkh@linuxfoundation.org>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: mu001999@outlook.com, stable@vger.kernel.org
Subject: Re: [PATCH 5.10.y, 5.4.y, 4.19.y] rtmutex: Drop rt_mutex::wait_lock before scheduling
Date: Tue, 10 Sep 2024 09:34:16 +0200 [thread overview]
Message-ID: <2024091010-mummified-shorty-9ed0@gregkh> (raw)
In-Reply-To: <87jzflcpwv.ffs@tglx>
On Mon, Sep 09, 2024 at 08:16:48AM +0200, Thomas Gleixner wrote:
>
> From: Roland Xu <mu001999@outlook.com>
>
> commit d33d26036a0274b472299d7dcdaa5fb34329f91b upstream.
>
> rt_mutex_handle_deadlock() is called with rt_mutex::wait_lock held. In the
> good case it returns with the lock held and in the deadlock case it emits a
> warning and goes into an endless scheduling loop with the lock held, which
> triggers the 'scheduling in atomic' warning.
>
> Unlock rt_mutex::wait_lock in the dead lock case before issuing the warning
> and dropping into the schedule for ever loop.
>
> [ tglx: Moved unlock before the WARN(), removed the pointless comment,
> massaged changelog, added Fixes tag ]
>
> Fixes: 3d5c9340d194 ("rtmutex: Handle deadlock detection smarter")
> Signed-off-by: Roland Xu <mu001999@outlook.com>
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> Cc: stable@vger.kernel.org
> Link: https://lore.kernel.org/all/ME0P300MB063599BEF0743B8FA339C2CECC802@ME0P300MB0635.AUSP300.PROD.OUTLOOK.COM
> ---
> Backport to 5.10.y, 5.4.y, 4.19.y
Now queued up, thanks!
greg k-h
prev parent reply other threads:[~2024-09-10 7:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-08 10:30 FAILED: patch "[PATCH] rtmutex: Drop rt_mutex::wait_lock before scheduling" failed to apply to 4.19-stable tree gregkh
2024-09-09 6:16 ` [PATCH 5.10.y, 5.4.y, 4.19.y] rtmutex: Drop rt_mutex::wait_lock before scheduling Thomas Gleixner
2024-09-10 7:34 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2024091010-mummified-shorty-9ed0@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=mu001999@outlook.com \
--cc=stable@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox